From e7d6b5457bcbdac370a4a7912766510253ec7f4b Mon Sep 17 00:00:00 2001 From: liqiangz Date: Wed, 19 May 2021 09:10:04 +0800 Subject: [PATCH] Fix: `!=` is not supported in oal when parameters are numbers (#6968) --- CHANGES.md | 1 + .../core/analysis/metrics/expression/NotEqualMatch.java | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index 4168f0740a..a8a232d61d 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -43,6 +43,7 @@ Release Notes. * Allow multiple definitions as fallback in metadata-service-mapping.yaml file. * Fix: NPE when configmap has no data. * Fix: Dynamic Configuration key `slowTraceSegmentThreshold` not work +* Fix: `!=` is not supported in oal when parameters are numbers. #### UI * Add logo for kong plugin. diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/NotEqualMatch.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/NotEqualMatch.java index 6475bc5257..5e9bfa1517 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/NotEqualMatch.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/NotEqualMatch.java @@ -23,6 +23,11 @@ import org.apache.skywalking.oap.server.core.analysis.metrics.annotation.FilterM @FilterMatcher public class NotEqualMatch { + + public boolean match(int left, int right) { + return left != right; + } + public boolean match(Object left, Object right) { return !Objects.equals(left, right); } -- GitLab