Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
apache
SkyWalking
提交
afe4cb0c
S
SkyWalking
项目概览
apache
/
SkyWalking
上一次同步 1 年多
通知
302
Star
21345
Fork
6091
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
SkyWalking
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
afe4cb0c
编写于
4月 27, 2021
作者:
W
wankai123
提交者:
GitHub
4月 27, 2021
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fix: Some incompatibles check codes didn't work in `PercentileFunction combine` (#6851)
上级
dfd7ebdc
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
12 addition
and
10 deletion
+12
-10
CHANGES.md
CHANGES.md
+1
-0
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/PercentileFunction.java
...rver/core/analysis/meter/function/PercentileFunction.java
+5
-5
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgHistogramPercentileFunction.java
...is/meter/function/avg/AvgHistogramPercentileFunction.java
+6
-5
未找到文件。
CHANGES.md
浏览文件 @
afe4cb0c
...
...
@@ -25,6 +25,7 @@ Release Notes.
*
Loop alarm into event system.
*
Support alarm tags.
*
Support WeLink as a channel of alarm notification.
*
Fix: Some defensive codes didn't work in
`PercentileFunction combine`
.
#### UI
*
Add logo for kong plugin.
...
...
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/PercentileFunction.java
浏览文件 @
afe4cb0c
...
...
@@ -131,16 +131,16 @@ public abstract class PercentileFunction extends Metrics implements AcceptableVa
);
return
true
;
}
if
(
ranks
.
size
()
>
0
)
{
if
(
this
.
ranks
.
size
()
>
0
)
{
IntList
ranksOfThat
=
percentile
.
getRanks
();
if
(
this
.
ranks
.
size
()
!=
ranks
.
size
())
{
if
(
this
.
ranks
.
size
()
!=
ranks
OfThat
.
size
())
{
log
.
warn
(
"Incompatible ranks size = [{}}] for current PercentileFunction[{}]"
,
ranks
.
size
(),
this
.
ranks
.
size
()
ranks
OfThat
.
size
(),
this
.
ranks
.
size
()
);
return
true
;
}
else
{
if
(!
this
.
ranks
.
equals
(
percentile
.
getRanks
()
))
{
log
.
warn
(
"Rank {} doesn't exist in the previous ranks {}"
,
percentile
.
getRanks
(),
ranks
);
if
(!
this
.
ranks
.
equals
(
ranksOfThat
))
{
log
.
warn
(
"Rank {} doesn't exist in the previous ranks {}"
,
ranksOfThat
,
this
.
ranks
);
return
true
;
}
}
...
...
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/avg/AvgHistogramPercentileFunction.java
浏览文件 @
afe4cb0c
...
...
@@ -157,15 +157,16 @@ public abstract class AvgHistogramPercentileFunction extends Metrics implements
public
boolean
combine
(
final
Metrics
metrics
)
{
AvgHistogramPercentileFunction
percentile
=
(
AvgHistogramPercentileFunction
)
metrics
;
if
(
ranks
.
size
()
>
0
)
{
if
(
this
.
ranks
.
size
()
!=
ranks
.
size
())
{
if
(
this
.
ranks
.
size
()
>
0
)
{
IntList
ranksOfThat
=
percentile
.
getRanks
();
if
(
this
.
ranks
.
size
()
!=
ranksOfThat
.
size
())
{
log
.
warn
(
"Incompatible ranks size = [{}}] for current PercentileFunction[{}]"
,
ranks
.
size
(),
this
.
ranks
.
size
()
ranks
OfThat
.
size
(),
this
.
ranks
.
size
()
);
return
true
;
}
else
{
if
(!
this
.
ranks
.
equals
(
percentile
.
getRanks
()
))
{
log
.
warn
(
"Rank {} doesn't exist in the previous ranks {}"
,
percentile
.
getRanks
(),
ranks
);
if
(!
this
.
ranks
.
equals
(
ranksOfThat
))
{
log
.
warn
(
"Rank {} doesn't exist in the previous ranks {}"
,
ranksOfThat
,
this
.
ranks
);
return
true
;
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录