From 6893fec8bb4742da8d76a499f48034196551ebdb Mon Sep 17 00:00:00 2001 From: Zhenxu Ke Date: Tue, 19 Jan 2021 16:53:06 +0800 Subject: [PATCH] Fix bug in `parseInternalErrorCode` where some error codes are never reached (#6226) --- CHANGES.md | 1 + .../oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 387c7eada3..fea05af65a 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -70,6 +70,7 @@ Release Notes. * Log collecting and query implementation * Support Alarm to feishu * Add the implementation of ConfigurationDiscovery on the OAP side. +* Fix bug in `parseInternalErrorCode` where some error codes are never reached. #### UI * Fix un-removed tags in trace query. diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java index ba9c69dc3f..0317d77954 100644 --- a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java +++ b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java @@ -202,7 +202,7 @@ public class LogEntry2MetricsAdapter { return "fault_injected"; } else if (responseFlags.getRateLimited()) { return "rate_limited"; - } else if (responseFlags.getUnauthorizedDetails() != null) { + } else if (responseFlags.hasUnauthorizedDetails()) { return "unauthorized_details"; } else if (responseFlags.getRateLimitServiceError()) { return "rate_limit_service_error"; -- GitLab