From 5ae51d2fc37ae53aa56e450fe85104451eadf919 Mon Sep 17 00:00:00 2001 From: peng-yongsheng <8082209@qq.com> Date: Sat, 21 Oct 2017 09:03:22 +0800 Subject: [PATCH] Fixed check style error. --- .../agentstream/worker/segment/buffer/OffsetManager.java | 6 +----- .../worker/segment/buffer/SegmentBufferReader.java | 6 +----- .../segment/standardization/ReferenceIdExchanger.java | 8 ++++---- .../worker/segment/standardization/SpanIdExchanger.java | 8 ++++---- 4 files changed, 10 insertions(+), 18 deletions(-) diff --git a/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/buffer/OffsetManager.java b/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/buffer/OffsetManager.java index e895b52c09..c2e64b34d3 100644 --- a/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/buffer/OffsetManager.java +++ b/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/buffer/OffsetManager.java @@ -142,11 +142,7 @@ public enum OffsetManager { class PrefixFileNameFilter implements FilenameFilter { @Override public boolean accept(File dir, String name) { - if (name.startsWith(OFFSET_FILE_PREFIX)) { - return true; - } else { - return false; - } + return name.startsWith(OFFSET_FILE_PREFIX); } } } diff --git a/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/buffer/SegmentBufferReader.java b/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/buffer/SegmentBufferReader.java index 775c6c9d63..3fd3f7db62 100644 --- a/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/buffer/SegmentBufferReader.java +++ b/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/buffer/SegmentBufferReader.java @@ -141,11 +141,7 @@ public enum SegmentBufferReader { class PrefixFileNameFilter implements FilenameFilter { @Override public boolean accept(File dir, String name) { - if (name.startsWith(SegmentBufferManager.DATA_FILE_PREFIX)) { - return true; - } else { - return false; - } + return name.startsWith(SegmentBufferManager.DATA_FILE_PREFIX); } } } diff --git a/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/standardization/ReferenceIdExchanger.java b/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/standardization/ReferenceIdExchanger.java index 683ba5ff3a..10b43955cd 100644 --- a/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/standardization/ReferenceIdExchanger.java +++ b/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/standardization/ReferenceIdExchanger.java @@ -33,13 +33,13 @@ public class ReferenceIdExchanger implements IdExchanger { private final Logger logger = LoggerFactory.getLogger(ReferenceIdExchanger.class); - private static ReferenceIdExchanger exchanger; + private static ReferenceIdExchanger EXCHANGER; public static ReferenceIdExchanger getInstance() { - if (exchanger == null) { - exchanger = new ReferenceIdExchanger(); + if (EXCHANGER == null) { + EXCHANGER = new ReferenceIdExchanger(); } - return exchanger; + return EXCHANGER; } @Override public boolean exchange(ReferenceDecorator standardBuilder, int applicationId) { diff --git a/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/standardization/SpanIdExchanger.java b/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/standardization/SpanIdExchanger.java index 2ab1c056f9..b06a1c5403 100644 --- a/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/standardization/SpanIdExchanger.java +++ b/apm-collector/apm-collector-agentstream/src/main/java/org/skywalking/apm/collector/agentstream/worker/segment/standardization/SpanIdExchanger.java @@ -28,13 +28,13 @@ import org.skywalking.apm.collector.core.util.StringUtils; */ public class SpanIdExchanger implements IdExchanger { - private static SpanIdExchanger exchanger; + private static SpanIdExchanger EXCHANGER; public static SpanIdExchanger getInstance() { - if (exchanger == null) { - exchanger = new SpanIdExchanger(); + if (EXCHANGER == null) { + EXCHANGER = new SpanIdExchanger(); } - return exchanger; + return EXCHANGER; } @Override public boolean exchange(SpanDecorator standardBuilder, int applicationId) { -- GitLab