From ac16fb6cc89ccd5383283f0b563e043fb377dc71 Mon Sep 17 00:00:00 2001
From: cherrylzhao <zhaojunv3@126.com>
Date: Mon, 4 Mar 2019 18:01:30 +0800
Subject: [PATCH] for #1963 add assertRemoveIfPresent test case for
 MySQLBinaryStatementRegistryTest.

---
 .../command/AllMySQLMySQLCommandPacketTests.java      |  4 ++--
 ...est.java => MySQLBinaryStatementRegistryTest.java} | 11 ++++++++++-
 2 files changed, 12 insertions(+), 3 deletions(-)
 rename sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/{MySQLMySQLBinaryStatementRegistryTest.java => MySQLBinaryStatementRegistryTest.java} (83%)

diff --git a/sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/AllMySQLMySQLCommandPacketTests.java b/sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/AllMySQLMySQLCommandPacketTests.java
index feeed773f5..398d227928 100644
--- a/sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/AllMySQLMySQLCommandPacketTests.java
+++ b/sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/AllMySQLMySQLCommandPacketTests.java
@@ -23,7 +23,7 @@ import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.ad
 import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.admin.quit.MySQLComQuitPacketTest;
 import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.query.MySQLColumnDefinition41PacketTest;
 import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.query.MySQLFieldCountPacketTest;
-import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.query.binary.MySQLMySQLBinaryStatementRegistryTest;
+import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.query.binary.MySQLBinaryStatementRegistryTest;
 import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.query.binary.close.MySQLComStmtClosePacketTest;
 import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.query.binary.execute.MySQLBinaryResultSetRowPacketTest;
 import org.apache.shardingsphere.shardingproxy.transport.mysql.packet.command.query.binary.execute.MySQLComStmtExecutePacketTest;
@@ -43,7 +43,7 @@ import org.junit.runners.Suite.SuiteClasses;
         MySQLCommandPacketTypeLoaderTest.class, 
         MySQLMySQLCommandPacketTypeTest.class, 
         MySQLMySQLCommandPacketFactoryTest.class, 
-        MySQLMySQLBinaryStatementRegistryTest.class, 
+        MySQLBinaryStatementRegistryTest.class,
         MySQLNullBitmapTest.class, 
         AllMySQLBinaryProtocolTests.class, 
         MySQLFieldCountPacketTest.class, 
diff --git a/sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/MySQLMySQLBinaryStatementRegistryTest.java b/sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/MySQLBinaryStatementRegistryTest.java
similarity index 83%
rename from sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/MySQLMySQLBinaryStatementRegistryTest.java
rename to sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/MySQLBinaryStatementRegistryTest.java
index ce5a6e0430..d532738d8f 100644
--- a/sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/MySQLMySQLBinaryStatementRegistryTest.java
+++ b/sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/test/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/MySQLBinaryStatementRegistryTest.java
@@ -23,9 +23,10 @@ import org.junit.Before;
 import org.junit.Test;
 
 import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertThat;
 
-public final class MySQLMySQLBinaryStatementRegistryTest {
+public final class MySQLBinaryStatementRegistryTest {
     
     private final String sql = "SELECT * FROM tbl WHERE id=?";
     
@@ -51,4 +52,12 @@ public final class MySQLMySQLBinaryStatementRegistryTest {
         assertThat(actual.getSql(), is(sql));
         assertThat(actual.getParametersCount(), is(1));
     }
+    
+    @Test
+    public void assertRemoveIfPresent() {
+        MySQLBinaryStatementRegistry.getInstance().register(sql, 1);
+        MySQLBinaryStatementRegistry.getInstance().remove(1);
+        MySQLBinaryStatement actual = MySQLBinaryStatementRegistry.getInstance().getBinaryStatement(1);
+        assertNull(actual);
+    }
 }
-- 
GitLab