diff --git a/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/config/DataSourceConfigurationTest.java b/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/config/DataSourceConfigurationTest.java index b0d0672be575bde7bfbce1246fd32ec95a4bfab5..b343e71c1ed1199e180534acf284de4575be367b 100644 --- a/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/config/DataSourceConfigurationTest.java +++ b/shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/config/DataSourceConfigurationTest.java @@ -57,7 +57,7 @@ public final class DataSourceConfigurationTest { @Test public void assertCreateDataSource() { - Map props = new HashMap<>(); + Map props = new HashMap<>(16, 1); props.put("driverClassName", "org.h2.Driver"); props.put("jdbcUrl", "jdbc:h2:mem:test;DB_CLOSE_DELAY=-1;DATABASE_TO_UPPER=false;MODE=MySQL"); props.put("username", "root"); @@ -110,14 +110,13 @@ public final class DataSourceConfigurationTest { DataSourceConfiguration originalDataSourceConfig = new DataSourceConfiguration(HikariDataSource.class.getName()); DataSourceConfiguration targetDataSourceConfiguration = new DataSourceConfiguration(HikariDataSource.class.getName()); originalDataSourceConfig.getProps().put("username", "root"); + targetDataSourceConfiguration.getProps().put("username", "root0"); assertThat(originalDataSourceConfig, not(targetDataSourceConfiguration)); - targetDataSourceConfiguration.getProps().put("username", "root"); - originalDataSourceConfig.getProps().put("password", "root"); - assertThat(originalDataSourceConfig, not(targetDataSourceConfiguration)); - assertFalse(originalDataSourceConfig.equals(null)); - originalDataSourceConfig = new DataSourceConfiguration(HikariDataSource.class.getName()); - targetDataSourceConfiguration = new DataSourceConfiguration(BasicDataSource.class.getName()); - assertThat(originalDataSourceConfig, not(targetDataSourceConfiguration)); + } + + @Test + public void assertEqualsWithNull() { + assertFalse(new DataSourceConfiguration(HikariDataSource.class.getName()).equals(null)); } @Test