From 4c08066f56b5708fa70c476c065c70b1ba2a5257 Mon Sep 17 00:00:00 2001 From: terrymanu Date: Wed, 18 Sep 2019 20:25:54 +0800 Subject: [PATCH] refactor RoutingResultValidator's constructor --- .../route/router/sharding/RoutingResultValidator.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/router/sharding/RoutingResultValidator.java b/sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/router/sharding/RoutingResultValidator.java index 5489f9b8d3..3a988fcc28 100644 --- a/sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/router/sharding/RoutingResultValidator.java +++ b/sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/router/sharding/RoutingResultValidator.java @@ -48,6 +48,7 @@ import java.util.LinkedList; * Routing result validator. * * @author sunbufu + * @author zhangliang */ public final class RoutingResultValidator { @@ -69,12 +70,8 @@ public final class RoutingResultValidator { this.metaData = metaData; this.shardingStatement = shardingStatement; this.shardingConditions = shardingConditions; - if (shardingRule.getRuleConfiguration().getMasterSlaveRuleConfigs().isEmpty()) { - checkDataSource = true; - } - if (shardingStatement.getSQLStatement() instanceof DMLStatement) { - checkTable = true; - } + checkDataSource = shardingRule.getRuleConfiguration().getMasterSlaveRuleConfigs().isEmpty(); + checkTable = shardingStatement.getSQLStatement() instanceof DMLStatement; } /** -- GitLab