From 48f71354524f6da0239b383a5511eb3737cdd510 Mon Sep 17 00:00:00 2001
From: sluk3r <sluk3r@qq.com>
Date: Wed, 9 Oct 2019 23:34:21 +0800
Subject: [PATCH] improved coverage for package of transaction (#3200)

* test case added for method of begin, commit, rollback

* test case added for method of begin, commit, rollback

* copyright added

* final added
---
 .../xa/XAShardingTransactionManagerTest.java  | 24 +++++++++++++++
 .../core/ResourceIDGeneratorTest.java         | 30 +++++++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 sharding-transaction/sharding-transaction-core/src/test/java/org/apache/shardingsphere/transaction/core/ResourceIDGeneratorTest.java

diff --git a/sharding-transaction/sharding-transaction-2pc/sharding-transaction-xa/sharding-transaction-xa-core/src/test/java/org/apache/shardingsphere/transaction/xa/XAShardingTransactionManagerTest.java b/sharding-transaction/sharding-transaction-2pc/sharding-transaction-xa/sharding-transaction-xa-core/src/test/java/org/apache/shardingsphere/transaction/xa/XAShardingTransactionManagerTest.java
index 45377d530f..331c0fadec 100644
--- a/sharding-transaction/sharding-transaction-2pc/sharding-transaction-xa/sharding-transaction-xa-core/src/test/java/org/apache/shardingsphere/transaction/xa/XAShardingTransactionManagerTest.java
+++ b/sharding-transaction/sharding-transaction-2pc/sharding-transaction-xa/sharding-transaction-xa-core/src/test/java/org/apache/shardingsphere/transaction/xa/XAShardingTransactionManagerTest.java
@@ -147,6 +147,30 @@ public final class XAShardingTransactionManagerTest {
         assertThat(cachedSingleXADataSourceMap.size(), is(0));
     }
     
+    @Test
+    public void assertBegin() throws Exception {
+        setCachedSingleXADataSourceMap("ds1");
+        xaShardingTransactionManager.begin();
+        verify(xaTransactionManager).getTransactionManager();
+        verify(xaTransactionManager.getTransactionManager()).begin();
+    }
+    
+    @Test
+    public void assertCommit() throws Exception {
+        setCachedSingleXADataSourceMap("ds1");
+        xaShardingTransactionManager.commit();
+        verify(xaTransactionManager).getTransactionManager();
+        verify(xaTransactionManager.getTransactionManager()).commit();
+    }
+    
+    @Test
+    public void assertRollback() throws Exception {
+        setCachedSingleXADataSourceMap("ds1");
+        xaShardingTransactionManager.rollback();
+        verify(xaTransactionManager).getTransactionManager();
+        verify(xaTransactionManager.getTransactionManager()).rollback();
+    }
+    
     @SneakyThrows
     @SuppressWarnings("unchecked")
     private Map<String, SingleXADataSource> getCachedSingleXADataSourceMap() {
diff --git a/sharding-transaction/sharding-transaction-core/src/test/java/org/apache/shardingsphere/transaction/core/ResourceIDGeneratorTest.java b/sharding-transaction/sharding-transaction-core/src/test/java/org/apache/shardingsphere/transaction/core/ResourceIDGeneratorTest.java
new file mode 100644
index 0000000000..fcd0816131
--- /dev/null
+++ b/sharding-transaction/sharding-transaction-core/src/test/java/org/apache/shardingsphere/transaction/core/ResourceIDGeneratorTest.java
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.transaction.core;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+
+public final class ResourceIDGeneratorTest {
+    
+    @Test
+    public void assertNextIdProperly() {
+        assertTrue(ResourceIDGenerator.getInstance().nextId().contains("resource"));
+    }
+}
-- 
GitLab