From f88bbbd637700401715bc3802601e7802b56b9ae Mon Sep 17 00:00:00 2001
From: QuakeWang <45645138+QuakeWang@users.noreply.github.com>
Date: Fri, 7 May 2021 20:58:23 +0800
Subject: [PATCH] [Improvement] Create RollViewLogRequestCommandTest.java
 (#5417)

* Create RollViewLogRequestCommandTest.java

Add a test case about RollViewLogRequestCommand

* Update pom.xml

add the test files in the parent pom
---
 .../log/RollViewLogRequestCommandTest.java    | 37 +++++++++++++++++++
 pom.xml                                       |  3 ++
 2 files changed, 40 insertions(+)
 create mode 100644 dolphinscheduler-remote/src/test/java/org/apache/dolphinscheduler/remote/command/log/RollViewLogRequestCommandTest.java

diff --git a/dolphinscheduler-remote/src/test/java/org/apache/dolphinscheduler/remote/command/log/RollViewLogRequestCommandTest.java b/dolphinscheduler-remote/src/test/java/org/apache/dolphinscheduler/remote/command/log/RollViewLogRequestCommandTest.java
new file mode 100644
index 000000000..2d55dcb58
--- /dev/null
+++ b/dolphinscheduler-remote/src/test/java/org/apache/dolphinscheduler/remote/command/log/RollViewLogRequestCommandTest.java
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.remote.command.log;
+
+import org.apache.dolphinscheduler.remote.command.Command;
+
+import org.junit.Test;
+
+import junit.framework.Assert;
+
+public class RollViewLogRequestCommandTest {
+
+    @Test
+    public void testConvert2Command() {
+        RollViewLogRequestCommand rollViewLogRequestCommand = new RollViewLogRequestCommand();
+        rollViewLogRequestCommand.setPath("/opt/test");
+        rollViewLogRequestCommand.setSkipLineNum(1);
+        rollViewLogRequestCommand.setLimit(1);
+        Command command = rollViewLogRequestCommand.convert2Command();
+        Assert.assertNotNull(command);
+    }
+}
diff --git a/pom.xml b/pom.xml
index 1d87b0d75..31a037cb2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -915,6 +915,9 @@
                         <include>**/remote/command/future/ResponseFutureTest.java</include>
                         <include>**/remote/command/log/RemoveTaskLogRequestCommandTest.java</include>
                         <include>**/remote/command/log/RemoveTaskLogResponseCommandTest.java</include>
+                        <include>**/remote/command/log/GetLogBytesRequestCommandTest.java</include>
+                        <include>**/remote/command/log/GetLogBytesResponseCommandTest.java</include>
+                        <include>**/remote/command/log/ViewLogRequestCommandTest.java</include>
                         <include>**/remote/utils/HostTest.java</include>
                         <include>**/remote/utils/NettyUtilTest.java</include>
                         <include>**/remote/NettyRemotingClientTest.java</include>
-- 
GitLab