From 02cdfe60b703299caeb10dc49607101e40520eba Mon Sep 17 00:00:00 2001 From: Dmitry Kozlov Date: Mon, 15 Nov 2010 21:14:18 +0300 Subject: [PATCH] ppp: fixed incorrect session termination if authentication failed --- accel-pptpd/ppp/ppp.c | 2 +- accel-pptpd/radius/acct.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/accel-pptpd/ppp/ppp.c b/accel-pptpd/ppp/ppp.c index ceefc1e..a26e644 100644 --- a/accel-pptpd/ppp/ppp.c +++ b/accel-pptpd/ppp/ppp.c @@ -397,7 +397,7 @@ void __export ppp_layer_finished(struct ppp_t *ppp, struct ppp_layer_data_t *d) list_for_each_entry(n, &ppp->layers, entry) { list_for_each_entry(d, &n->items, entry) { - if (!d->finished) + if (d->starting && !d->finished) return; } } diff --git a/accel-pptpd/radius/acct.c b/accel-pptpd/radius/acct.c index e056182..cc0fdea 100644 --- a/accel-pptpd/radius/acct.c +++ b/accel-pptpd/radius/acct.c @@ -119,8 +119,8 @@ static void rad_acct_timeout(struct triton_timer_t *t) dt = ts - req->rpd->acct_timestamp; if (dt > conf_acct_timeout) { - log_ppp_warn("radius: acct: no response, terminating session...\n"); - ppp_terminate(req->rpd->ppp, 0, TERM_NAS_ERROR); + log_ppp_warn("radius:acct: no response, terminating session...\n"); + ppp_terminate(req->rpd->ppp, TERM_NAS_ERROR, 0); return; } if (dt > conf_acct_timeout / 2) { -- GitLab