diff --git a/java/com/google/scrollview/ScrollView.java b/java/com/google/scrollview/ScrollView.java index 66dd398feb8f429e33063ca37cfc6f896ee6f311..e1a02dae351be5e65ba0ae5c08a2f26c7f9a5241 100644 --- a/java/com/google/scrollview/ScrollView.java +++ b/java/com/google/scrollview/ScrollView.java @@ -371,9 +371,8 @@ public class ScrollView { intPattern = Pattern.compile("[0-9-][0-9]*"); floatPattern = Pattern.compile("[0-9-][0-9]*\\.[0-9]*"); - try { - // Open a socket to listen on. - ServerSocket serverSocket = new ServerSocket(SERVER_PORT); + // Open a socket to listen on. + try (ServerSocket serverSocket = new ServerSocket(SERVER_PORT)) { System.out.println("Socket started on port " + SERVER_PORT); // Wait (blocking) for an incoming connection diff --git a/java/com/google/scrollview/ui/SVCheckboxMenuItem.java b/java/com/google/scrollview/ui/SVCheckboxMenuItem.java index 7559702dc11f303ed010e81c2f2eb88dadf7e5a9..78be8e0b346773d591d6278e5103d42b2be3b1fb 100644 --- a/java/com/google/scrollview/ui/SVCheckboxMenuItem.java +++ b/java/com/google/scrollview/ui/SVCheckboxMenuItem.java @@ -30,7 +30,6 @@ import javax.swing.JCheckBoxMenuItem; */ class SVCheckboxMenuItem extends SVAbstractMenuItem { public String value = null; - public String desc = null; public boolean bvalue; SVCheckboxMenuItem(int id, String name, boolean val) { diff --git a/java/com/google/scrollview/ui/SVWindow.java b/java/com/google/scrollview/ui/SVWindow.java index 267bfdda039c3253be6e140b87b85a1e300331a7..ec16bd8a6d5c9ea89eb625c8b5b02e68df0ed25e 100644 --- a/java/com/google/scrollview/ui/SVWindow.java +++ b/java/com/google/scrollview/ui/SVWindow.java @@ -204,10 +204,20 @@ public class SVWindow extends JFrame { super(name); // Provide defaults for sizes. - if (sizeX == 0) sizeX = canvasSizeX; - if (sizeY == 0) sizeY = canvasSizeY; - if (canvasSizeX == 0) canvasSizeX = sizeX; - if (canvasSizeY == 0) canvasSizeY = sizeY; + if (sizeX <= 0) sizeX = canvasSizeX; + if (sizeY <= 0) sizeY = canvasSizeY; + if (canvasSizeX <= 0) canvasSizeX = sizeX; + if (canvasSizeY <= 0) canvasSizeY = sizeY; + + // Avoid later division by zero. + if (sizeX <= 0) { + sizeX = 1; + canvasSizeX = sizeX; + } + if (sizeY <= 0) { + sizeY = 1; + canvasSizeY = sizeY; + } // Initialize variables nrWindows++;