From 5d25a0b690eb1e77d2f9723b3fee1a3bc98f777b Mon Sep 17 00:00:00 2001
From: geraldglynn <gerald.glynn@smartbear.com>
Date: Thu, 16 May 2019 04:45:07 +0100
Subject: [PATCH] improvement: add `isShown` check to <ModelCollapse />'s prop
 `expanded` logic (via #5331)

---
 src/core/components/models.jsx | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/core/components/models.jsx b/src/core/components/models.jsx
index d23020bb..28c3bd67 100644
--- a/src/core/components/models.jsx
+++ b/src/core/components/models.jsx
@@ -62,10 +62,11 @@ export default class Models extends Component {
 
             const schema = Map.isMap(schemaValue) ? schemaValue : Im.Map()
             const rawSchema = Map.isMap(rawSchemaValue) ? rawSchemaValue : Im.Map()
-            
+
             const displayName = schema.get("title") || rawSchema.get("title") || name
+            const isShown = layoutSelectors.isShown( ["models", name], false )
 
-            if(layoutSelectors.isShown(["models", name], false) && (schema.size === 0 && rawSchema.size > 0)) {
+            if( isShown && (schema.size === 0 && rawSchema.size > 0) ) {
               // Firing an action in a container render is not great,
               // but it works for now.
               this.props.specActions.requestResolvedSubtree([...this.getSchemaBasePath(), name])
@@ -100,7 +101,7 @@ export default class Models extends Component {
                 displayName={displayName}
                 modelName={name}
                 hideSelfOnExpand={true}
-                expanded={defaultModelsExpandDepth > 1}
+                expanded={ defaultModelsExpandDepth > 0 && isShown }
                 >{content}</ModelCollapse>
               </div>
           }).toArray()
-- 
GitLab