From 7ed460bd035031a5ebc84b236d5b974d705ff385 Mon Sep 17 00:00:00 2001
From: Cary Xu <klxu@taosdata.com>
Date: Sat, 14 Aug 2021 11:09:14 +0800
Subject: [PATCH] code optimization

---
 src/wal/src/walWrite.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/wal/src/walWrite.c b/src/wal/src/walWrite.c
index 9590aba224..e991bf02aa 100644
--- a/src/wal/src/walWrite.c
+++ b/src/wal/src/walWrite.c
@@ -388,7 +388,7 @@ static int walSMemRowCheck(SWalHead *pHead) {
       }
       pBlk = (SSubmitBlk *)POINTER_SHIFT(pBlk, sizeof(SSubmitBlk) + dataLen);
     }
-
+    ASSERT(nTotalRows >= 0);
     SWalHead *pWalHead = (SWalHead *)calloc(sizeof(SWalHead) + pHead->len + nTotalRows * sizeof(uint8_t), 1);
     if (pWalHead == NULL) {
       return -1;
@@ -544,6 +544,8 @@ static int32_t walRestoreWalFile(SWal *pWal, void *pVnode, FWalWrite writeFp, ch
     if (0 != walSMemRowCheck(pHead)) {
       wError("vgId:%d, restore wal, fileId:%" PRId64 " hver:%" PRIu64 " wver:%" PRIu64 " len:%d offset:%" PRId64,
              pWal->vgId, fileId, pHead->version, pWal->version, pHead->len, offset);
+      tfClose(tfd);
+      tfree(buffer);
       return TAOS_SYSTEM_ERROR(errno);
     }
     (*writeFp)(pVnode, pHead, TAOS_QTYPE_WAL, NULL);
-- 
GitLab