From af5dcda481fc5823bdcfedd4b56034fb5a461109 Mon Sep 17 00:00:00 2001
From: dongzhihong <dzhwinter@gmail.com>
Date: Sun, 4 Mar 2018 22:43:36 +0800
Subject: [PATCH] "add testing"

---
 paddle/fluid/recordio/header_test.cc | 11 +----------
 paddle/fluid/recordio/writer.cc      |  7 ++++---
 2 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/paddle/fluid/recordio/header_test.cc b/paddle/fluid/recordio/header_test.cc
index ae8201ab00a..991ea05ec14 100644
--- a/paddle/fluid/recordio/header_test.cc
+++ b/paddle/fluid/recordio/header_test.cc
@@ -32,14 +32,5 @@ TEST(Recordio, ChunkHead) {
   std::ostringstream oss2;
   hdr2.Write(oss2);
   EXPECT_STREQ(oss2.str().c_str(), oss.str().c_str());
-}
-
-TEST(Recordio, Stream) {
-  Header hdr(0, 1, static_cast<Compressor>(2), 3);
-  std::ostringstream oss1;
-  hdr.Write(oss1);
-
-  std::ostringstream oss2;
-  oss2 << hdr;
-  EXPECT_STREQ(oss2.str().c_str(), oss1.str().c_str());
+  EXPECT_EQ(hdr == hdr2);
 }
diff --git a/paddle/fluid/recordio/writer.cc b/paddle/fluid/recordio/writer.cc
index 9383199889d..08d3d2c5778 100644
--- a/paddle/fluid/recordio/writer.cc
+++ b/paddle/fluid/recordio/writer.cc
@@ -29,13 +29,14 @@ Writer::Writer(std::ostream& os, int maxChunkSize, int compressor)
   chunk_.reset(new Chunk);
 }
 
-size_t Writer::Write(const std::string& buf) {}
+size_t Writer::Write(const std::string& buf) { return Write(std::string(buf)); }
 
 size_t Writer::Write(const char* buf, size_t length) {
-  // std::string s(buf, length);
-  Write(std::string(buf, length));
+  return Write(std::string(buf, length));
 }
 
+size_t Writer::Write(std::string&& buf) {}
+
 void Writer::Close() {
   stream_.flush();
   stream_.setstate(std::ios::eofbit);
-- 
GitLab