diff --git a/paddle/fluid/recordio/header_test.cc b/paddle/fluid/recordio/header_test.cc index ae8201ab00a2e6156b35b45f9c07e2b1f032bc39..991ea05ec14e664b351661f7a2f968fdadafafb9 100644 --- a/paddle/fluid/recordio/header_test.cc +++ b/paddle/fluid/recordio/header_test.cc @@ -32,14 +32,5 @@ TEST(Recordio, ChunkHead) { std::ostringstream oss2; hdr2.Write(oss2); EXPECT_STREQ(oss2.str().c_str(), oss.str().c_str()); -} - -TEST(Recordio, Stream) { - Header hdr(0, 1, static_cast(2), 3); - std::ostringstream oss1; - hdr.Write(oss1); - - std::ostringstream oss2; - oss2 << hdr; - EXPECT_STREQ(oss2.str().c_str(), oss1.str().c_str()); + EXPECT_EQ(hdr == hdr2); } diff --git a/paddle/fluid/recordio/writer.cc b/paddle/fluid/recordio/writer.cc index 9383199889d5ec14d7a02656f2f01eda636a5728..08d3d2c5778b4b67a3b2671742b6abbc5a1bc205 100644 --- a/paddle/fluid/recordio/writer.cc +++ b/paddle/fluid/recordio/writer.cc @@ -29,13 +29,14 @@ Writer::Writer(std::ostream& os, int maxChunkSize, int compressor) chunk_.reset(new Chunk); } -size_t Writer::Write(const std::string& buf) {} +size_t Writer::Write(const std::string& buf) { return Write(std::string(buf)); } size_t Writer::Write(const char* buf, size_t length) { - // std::string s(buf, length); - Write(std::string(buf, length)); + return Write(std::string(buf, length)); } +size_t Writer::Write(std::string&& buf) {} + void Writer::Close() { stream_.flush(); stream_.setstate(std::ios::eofbit);