From 2961e5959af02a2085fd854fc95174794a8cc1a2 Mon Sep 17 00:00:00 2001 From: tangwei12 Date: Mon, 22 Feb 2021 14:44:01 +0800 Subject: [PATCH] change fleet reviewer (#31069) (#31086) * change reviewer, test=document Change-Id: I7592ee5c93bd580300ce39df885b603597b09026 * Update check_file_diff_approvals.sh test=document_fix --- tools/check_file_diff_approvals.sh | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tools/check_file_diff_approvals.sh b/tools/check_file_diff_approvals.sh index d9b3bd1ff18..6a6102869bd 100644 --- a/tools/check_file_diff_approvals.sh +++ b/tools/check_file_diff_approvals.sh @@ -135,13 +135,16 @@ for API_FILE in ${API_FILES[*]}; do echo_line="You must have one TPM (jzhang533) approval for the api whitelist for the tools/wlist.json.\n" check_approval 1 29231 elif [ "${API_FILE}" == "python/paddle/distributed/fleet/__init__.py" ]; then - echo_line="You must have (guru4elephant,raindrops2sea) approval for ${API_FILE} changes " - check_approval 1 35550832 38231817 + echo_line="You must have (fuyinno4 (Recommend), raindrops2sea) approval for ${API_FILE} changes" + check_approval 1 35824027 38231817 elif [ "${API_FILE}" == "python/paddle/distributed/__init__.py" ]; then - echo_line="You must have (guru4elephant,raindrops2sea) approval for ${API_FILE} changes " - check_approval 1 35550832 38231817 - elif [ "${API_FILE}" == "paddle/scripts/paddle_build.bat" ]; then - echo_line="You must have one RD (zhouwei25 (Recommend), luotao1) approval for ${API_FILE} changes, which manages all Paddle CI task on Windows.\n" + echo_line="You must have (fuyinno4 (Recommend), raindrops2sea) approval for ${API_FILE} changes" + check_approval 1 35824027 38231817 + elif [ "${API_FILE}" == "paddle/scripts/paddle_build.bat" ] || [ "${API_FILE}" == "tools/windows/run_unittests.sh" ]; then + echo_line="You must have one RD (zhouwei25 (Recommend), luotao1) approval for ${API_FILE} changes, which manages the Paddle CI task on Windows.\n" + check_approval 1 52485244 6836917 + elif [ "${API_FILE}" == "tools/parallel_UT_rule.py" ]; then + echo_line="You must have one RD (zhouwei25 (Recommend), luotao1) approval for ${API_FILE} changes, which manages the rule of running unittest with a same GPU. If the unittest failed due to Insufficient GPU memory or CUBLAS_STATUS_ALLOC_FAILED, you can remove it from ${API_FILE}.\n" check_approval 1 52485244 6836917 elif [ "${API_FILE}" == "python/paddle/fluid/parallel_executor.py" ]; then echo_line="You must have one RD (Xreki,luotao1,zhhsplendid) approval for ${API_FILE}, which manages the underlying code for PaddlePaddle.\n" -- GitLab