From 1f3029cb54ce62d2cb65d2ecc98af8b5776676e6 Mon Sep 17 00:00:00 2001 From: zhupengyang Date: Wed, 25 Dec 2019 09:42:42 +0800 Subject: [PATCH] ci check for check_shape_white_list.py (#21859) --- .../tests/unittests/white_list/check_shape_white_list.py | 2 +- tools/check_api_approvals.sh | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/python/paddle/fluid/tests/unittests/white_list/check_shape_white_list.py b/python/paddle/fluid/tests/unittests/white_list/check_shape_white_list.py index 11d08970b56..6a8df021642 100644 --- a/python/paddle/fluid/tests/unittests/white_list/check_shape_white_list.py +++ b/python/paddle/fluid/tests/unittests/white_list/check_shape_white_list.py @@ -13,7 +13,7 @@ # limitations under the License. NOT_CHECK_OP_LIST = [ - # increment's input must be 1-d and only has one data + # The increment's input must be 1-d and only has one data 'increment' ] diff --git a/tools/check_api_approvals.sh b/tools/check_api_approvals.sh index 03d93355645..c105f1d399c 100644 --- a/tools/check_api_approvals.sh +++ b/tools/check_api_approvals.sh @@ -27,6 +27,7 @@ API_FILES=("CMakeLists.txt" "python/paddle/fluid/backward.py" "paddle/fluid/operators/distributed/send_recv.proto.in" "paddle/fluid/framework/unused_var_check.cc" + "python/paddle/fluid/tests/unittests/white_list/check_shape_white_list.py" "python/paddle/fluid/tests/unittests/white_list/op_check_grad_white_list.py") approval_line=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000` @@ -104,6 +105,9 @@ for API_FILE in ${API_FILES[*]}; do elif [ "${API_FILE}" == "paddle/fluid/framework/unused_var_check.cc" ];then echo_line="You must have one RD (zhiqiu (Recommend) , sneaxiy or luotao1) approval for the paddle/fluid/framework/unused_var_check.cc, which manages the white list of operators that have unused input variables. Before change the white list, please read the specification [https://github.com/PaddlePaddle/Paddle/wiki/OP-Should-Not-Have-Unused-Input] and try to refine code first. \n" check_approval 1 6888866 32832641 6836917 + elif [ "${API_FILE}" == "python/paddle/fluid/tests/unittests/white_list/check_shape_white_list.py" ];then + echo_line="You must have one RD (hong19860320 (Recommend), luotao1, phlrain) approval for the changes of check_shape_white_list.py, which manages the white list of operators with limited input size. The op test must have at least one test case with input size greater than or equal to 100. For more information, please refer to: https://github.com/PaddlePaddle/Paddle/wiki/OP-Test-Input-Shape-Requirements. \n" + check_approval 1 9973393 6836917 43953930 elif [ "${API_FILE}" == "python/paddle/fluid/tests/unittests/white_list/op_check_grad_white_list.py" ];then echo_line="You must have one RD (zhangting2020 (Recommend), luotao1 or phlrain) approval for the python/paddle/fluid/tests/unittests/white_list/op_check_grad_white_list.py, which manages the white list of operators without gradient. For more information, please refer to: https://github.com/PaddlePaddle/Paddle/wiki/Gradient-Check-Is-Required-for-Op-Test. \n" check_approval 1 26615455 6836917 43953930 -- GitLab