diff --git a/oneflow/core/kernel/hinge_loss_kernel.cpp b/oneflow/core/kernel/hinge_loss_kernel.cpp index af27c7190ce0c08ed28a04c50d3fc3af4f8ba0ea..1f16de3436203558236e08b19822e71c4a498092 100644 --- a/oneflow/core/kernel/hinge_loss_kernel.cpp +++ b/oneflow/core/kernel/hinge_loss_kernel.cpp @@ -57,10 +57,6 @@ struct HingeLossKernelUtil { KernelUtil::Mul(ctx, piece_size * pre_dim, tmp_diff, tmp_diff, tmp); KernelUtil::RowSum(ctx, piece_size, pre_dim, tmp, loss); - /*for (int64_t i = 0; i < piece_size; ++i) { - KernelUtil::Dot(ctx, pre_dim, tmp_diff + i * pre_dim, 1, - tmp_diff + i * pre_dim, 1, loss + i); - }*/ break; default: LOG(FATAL) << "Invalid norm method in " << op_conf.name(); } diff --git a/oneflow/core/kernel/hinge_loss_kernel.cu b/oneflow/core/kernel/hinge_loss_kernel.cu index 74cb90b113d407ff5a6bc3c686b5843990678048..d1873631499e429053456cc1c0df868e3e8c08d8 100644 --- a/oneflow/core/kernel/hinge_loss_kernel.cu +++ b/oneflow/core/kernel/hinge_loss_kernel.cu @@ -63,10 +63,6 @@ struct HingeLossKernelUtil { KernelUtil::RowSum(ctx, piece_size, pre_dim, tmp, loss, tmp_storage, sizeof(PredType) * piece_size * pre_dim); - /*for (int64_t i = 0; i < piece_size; ++i) { - KernelUtil::Dot(ctx, pre_dim, tmp_diff + i * pre_dim, 1, - tmp_diff + i * pre_dim, 1, loss + i); - }*/ break; default: LOG(FATAL) << "Invalid norm method in " << op_conf.name(); } diff --git a/oneflow/core/operator/op_conf.proto b/oneflow/core/operator/op_conf.proto index 1dfd084efa173b090985c034b7f94344ac968ae2..ad2887499a95c879d484c1794ba7ee1d67bd27db 100644 --- a/oneflow/core/operator/op_conf.proto +++ b/oneflow/core/operator/op_conf.proto @@ -629,6 +629,7 @@ message MultiplyOpConf { required string in_1 = 2; required string out = 4; } + enum Norm { L1 = 1; L2 = 2;