From c6486e2b4d71d8e1830b48f43ac4c84d8b06b0fb Mon Sep 17 00:00:00 2001
From: Jesse Glick <jglick@cloudbees.com>
Date: Mon, 15 Dec 2014 16:16:29 -0500
Subject: [PATCH] #1406 silently skipped the call to moveDirectory in case
 newBuildDir.isDirectory(), rather than throwing an IOE as renameTo does. Also
 deleting apparently useless call to forceMkdir.

---
 core/src/main/java/hudson/model/Job.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/core/src/main/java/hudson/model/Job.java b/core/src/main/java/hudson/model/Job.java
index 21ff3716c7..2addad98b0 100644
--- a/core/src/main/java/hudson/model/Job.java
+++ b/core/src/main/java/hudson/model/Job.java
@@ -654,8 +654,7 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
         File oldBuildDir = getBuildDir();
         super.movedTo(destination, newItem, destDir);
         File newBuildDir = getBuildDir();
-        if (oldBuildDir.isDirectory() && !newBuildDir.isDirectory()) {
-            FileUtils.forceMkdir(destDir.getParentFile());
+        if (oldBuildDir.isDirectory()) {
             FileUtils.moveDirectory(oldBuildDir, newBuildDir);
         }
     }
-- 
GitLab