From c096d49c37a6ca798120c552d4a835cf9f4bcd7a Mon Sep 17 00:00:00 2001
From: Jesse Glick <jglick@cloudbees.com>
Date: Tue, 14 Mar 2017 16:38:42 -0400
Subject: [PATCH] =?UTF-8?q?Non-Serializable=20SecurityRealm=E2=80=99s.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../security/TokenBasedRememberMeServices2Test.groovy  | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/test/src/test/groovy/hudson/security/TokenBasedRememberMeServices2Test.groovy b/test/src/test/groovy/hudson/security/TokenBasedRememberMeServices2Test.groovy
index 4796f12b5b..d0c6ae2880 100644
--- a/test/src/test/groovy/hudson/security/TokenBasedRememberMeServices2Test.groovy
+++ b/test/src/test/groovy/hudson/security/TokenBasedRememberMeServices2Test.groovy
@@ -9,6 +9,7 @@ import org.acegisecurity.ui.rememberme.TokenBasedRememberMeServices
 import org.acegisecurity.userdetails.User
 import org.acegisecurity.userdetails.UserDetails
 import org.acegisecurity.userdetails.UsernameNotFoundException
+import org.junit.Before
 import com.gargoylesoftware.htmlunit.util.Cookie
 import org.junit.Rule
 import org.junit.Test
@@ -33,7 +34,10 @@ class TokenBasedRememberMeServices2Test {
     @Rule
     public LoggerRule logging = new LoggerRule()
 
-    private boolean failureInduced;
+    private static boolean failureInduced;
+
+    @Before
+    public void resetFailureInduced() {failureInduced = false}
 
     @Test
     public void rememberMeAutoLoginFailure()  {
@@ -66,7 +70,7 @@ class TokenBasedRememberMeServices2Test {
         wc.cookieManager.getCookie(TokenBasedRememberMeServices2.ACEGI_SECURITY_HASHED_REMEMBER_ME_COOKIE_KEY)
     }
 
-    private class InvalidUserWhenLoggingBackInRealm extends AbstractPasswordBasedSecurityRealm {
+    private static class InvalidUserWhenLoggingBackInRealm extends AbstractPasswordBasedSecurityRealm {
         @Override
         protected UserDetails authenticate(String username, String password) throws AuthenticationException {
             if (username==password)
@@ -115,7 +119,7 @@ class TokenBasedRememberMeServices2Test {
         }
     }
 
-    private class StupidRealm extends InvalidUserWhenLoggingBackInRealm {
+    private static class StupidRealm extends InvalidUserWhenLoggingBackInRealm {
         @Override
         UserDetails loadUserByUsername(String username) throws UsernameNotFoundException, DataAccessException {
             failureInduced = true
-- 
GitLab