From bc7af314ebd8f260482b96c3ad7d4d7a235692c5 Mon Sep 17 00:00:00 2001
From: kohsuke <kohsuke@71c3de6d-444a-0410-be80-ed276b4c234a>
Date: Fri, 20 Mar 2009 23:37:35 +0000
Subject: [PATCH] BuildSteps should all use BuildStepDescriptor.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16414 71c3de6d-444a-0410-be80-ed276b4c234a
---
 core/src/main/java/hudson/tasks/Ant.java       | 6 +++++-
 core/src/main/java/hudson/tasks/BatchFile.java | 7 ++++++-
 core/src/main/java/hudson/tasks/Maven.java     | 6 +++++-
 core/src/main/java/hudson/tasks/Shell.java     | 7 ++++++-
 4 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/core/src/main/java/hudson/tasks/Ant.java b/core/src/main/java/hudson/tasks/Ant.java
index c8f2166880..51e30b791d 100644
--- a/core/src/main/java/hudson/tasks/Ant.java
+++ b/core/src/main/java/hudson/tasks/Ant.java
@@ -248,7 +248,7 @@ public class Ant extends Builder {
     }
 
     @Extension
-    public static class DescriptorImpl extends Descriptor<Builder> {
+    public static class DescriptorImpl extends BuildStepDescriptor<Builder> {
         @CopyOnWrite
         private volatile AntInstallation[] installations = new AntInstallation[0];
 
@@ -256,6 +256,10 @@ public class Ant extends Builder {
             load();
         }
 
+        public boolean isApplicable(Class<? extends AbstractProject> jobType) {
+            return true;
+        }
+
         protected DescriptorImpl(Class<? extends Ant> clazz) {
             super(clazz);
         }
diff --git a/core/src/main/java/hudson/tasks/BatchFile.java b/core/src/main/java/hudson/tasks/BatchFile.java
index bfa9fa2e3c..6fa8c57db7 100644
--- a/core/src/main/java/hudson/tasks/BatchFile.java
+++ b/core/src/main/java/hudson/tasks/BatchFile.java
@@ -26,6 +26,7 @@ package hudson.tasks;
 import hudson.FilePath;
 import hudson.Extension;
 import hudson.model.Descriptor;
+import hudson.model.AbstractProject;
 import net.sf.json.JSONObject;
 import org.kohsuke.stapler.StaplerRequest;
 
@@ -52,7 +53,7 @@ public class BatchFile extends CommandInterpreter {
     }
 
     @Extension
-    public static final class DescriptorImpl extends Descriptor<Builder> {
+    public static final class DescriptorImpl extends BuildStepDescriptor<Builder> {
         public String getHelpFile() {
             return "/help/project-config/batch.html";
         }
@@ -64,5 +65,9 @@ public class BatchFile extends CommandInterpreter {
         public Builder newInstance(StaplerRequest req, JSONObject data) {
             return new BatchFile(data.getString("batchFile"));
         }
+
+        public boolean isApplicable(Class<? extends AbstractProject> jobType) {
+            return true;
+        }
     }
 }
diff --git a/core/src/main/java/hudson/tasks/Maven.java b/core/src/main/java/hudson/tasks/Maven.java
index fe31bcc778..55558d8ea2 100644
--- a/core/src/main/java/hudson/tasks/Maven.java
+++ b/core/src/main/java/hudson/tasks/Maven.java
@@ -272,7 +272,7 @@ public class Maven extends Builder {
     public static DescriptorImpl DESCRIPTOR;
 
     @Extension
-    public static final class DescriptorImpl extends Descriptor<Builder> {
+    public static final class DescriptorImpl extends BuildStepDescriptor<Builder> {
         @CopyOnWrite
         private volatile MavenInstallation[] installations = new MavenInstallation[0];
 
@@ -281,6 +281,10 @@ public class Maven extends Builder {
             load();
         }
 
+        public boolean isApplicable(Class<? extends AbstractProject> jobType) {
+            return true;
+        }
+
         protected void convert(Map<String, Object> oldPropertyBag) {
             if(oldPropertyBag.containsKey("installations"))
                 installations = (MavenInstallation[]) oldPropertyBag.get("installations");
diff --git a/core/src/main/java/hudson/tasks/Shell.java b/core/src/main/java/hudson/tasks/Shell.java
index 285a852aa7..17a4eb6b85 100644
--- a/core/src/main/java/hudson/tasks/Shell.java
+++ b/core/src/main/java/hudson/tasks/Shell.java
@@ -27,6 +27,7 @@ import hudson.FilePath;
 import hudson.Util;
 import hudson.Extension;
 import hudson.model.Descriptor;
+import hudson.model.AbstractProject;
 import static hudson.model.Hudson.isWindows;
 import hudson.util.FormFieldValidator;
 import net.sf.json.JSONObject;
@@ -99,7 +100,7 @@ public class Shell extends CommandInterpreter {
     }
 
     @Extension
-    public static final class DescriptorImpl extends Descriptor<Builder> {
+    public static final class DescriptorImpl extends BuildStepDescriptor<Builder> {
         /**
          * Shell executable, or null to default.
          */
@@ -109,6 +110,10 @@ public class Shell extends CommandInterpreter {
             load();
         }
 
+        public boolean isApplicable(Class<? extends AbstractProject> jobType) {
+            return true;
+        }
+
         protected void convert(Map<String, Object> oldPropertyBag) {
             shell = (String)oldPropertyBag.get("shell");
         }
-- 
GitLab