From b00aeddf4bc58a35d0aca67eced5ea89a78b1bf2 Mon Sep 17 00:00:00 2001 From: Matt Moore Date: Sat, 14 Jun 2014 16:36:59 -0700 Subject: [PATCH] Null check the 'properties' element of the json message before attempting to 'rebuild' the 'DescribableList' --- core/src/main/java/hudson/model/Job.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/model/Job.java b/core/src/main/java/hudson/model/Job.java index f3a7abc867..b14f76e03a 100644 --- a/core/src/main/java/hudson/model/Job.java +++ b/core/src/main/java/hudson/model/Job.java @@ -1144,7 +1144,12 @@ public abstract class Job, RunT extends Run, JobPropertyDescriptor> t = new DescribableList, JobPropertyDescriptor>(NOOP,getAllProperties()); - t.rebuild(req,json.optJSONObject("properties"),JobPropertyDescriptor.getPropertyDescriptors(Job.this.getClass())); + JSONObject jsonProperties = json.optJSONObject("properties"); + if (jsonProperties != null) { + t.rebuild(req,jsonProperties,JobPropertyDescriptor.getPropertyDescriptors(Job.this.getClass())); + } else { + t.clear(); + } properties.clear(); for (JobProperty p : t) { p.setOwner(this); -- GitLab