From 9bf265e5762f1d27e8560b716a25e2dbb031c8fc Mon Sep 17 00:00:00 2001
From: Jesse Glick <jglick@cloudbees.com>
Date: Thu, 10 Apr 2014 17:25:57 -0400
Subject: [PATCH] FindBugs annotations to catch the likes of JENKINS-19852.

---
 .../src/main/java/hudson/model/ReconfigurableDescribable.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/core/src/main/java/hudson/model/ReconfigurableDescribable.java b/core/src/main/java/hudson/model/ReconfigurableDescribable.java
index 7738089b1d..e9dd8c2f6c 100644
--- a/core/src/main/java/hudson/model/ReconfigurableDescribable.java
+++ b/core/src/main/java/hudson/model/ReconfigurableDescribable.java
@@ -25,6 +25,8 @@ package hudson.model;
 
 import hudson.model.Descriptor.FormException;
 import hudson.slaves.NodeProperty;
+import javax.annotation.CheckForNull;
+import javax.annotation.Nonnull;
 import net.sf.json.JSONObject;
 import org.kohsuke.stapler.StaplerRequest;
 
@@ -77,5 +79,5 @@ public interface ReconfigurableDescribable<T extends ReconfigurableDescribable<T
      * @return
      *      The new instance. To not to create an instance of a describable, return null.
      */
-    T reconfigure(StaplerRequest req, JSONObject form) throws FormException;
+    @CheckForNull T reconfigure(@Nonnull StaplerRequest req, @CheckForNull JSONObject form) throws FormException;
 }
-- 
GitLab