From 8a2849b441226ceaba282906af3fe3820fdfa03d Mon Sep 17 00:00:00 2001
From: Jesse Glick <jglick@cloudbees.com>
Date: Fri, 13 Nov 2015 17:53:50 -0500
Subject: [PATCH] [FIXED JENKINS-31518] Translate Job.logRotator to
 BuildDiscarderProperty more seamlessly.

---
 core/src/main/java/hudson/model/Job.java      |  19 +++++++++++---
 .../model/BuildDiscarderPropertyTest.java     |  24 ++++++++++++++++++
 .../buildDiscarderField.zip                   | Bin 0 -> 499 bytes
 3 files changed, 40 insertions(+), 3 deletions(-)
 create mode 100644 test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/buildDiscarderField.zip

diff --git a/core/src/main/java/hudson/model/Job.java b/core/src/main/java/hudson/model/Job.java
index 07684f9e9d..d60f144d55 100644
--- a/core/src/main/java/hudson/model/Job.java
+++ b/core/src/main/java/hudson/model/Job.java
@@ -430,7 +430,7 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
      * Returns the configured build discarder for this job, via {@link BuildDiscarderProperty}, or null if none.
      */
     public synchronized BuildDiscarder getBuildDiscarder() {
-        BuildDiscarderProperty prop = getProperty(BuildDiscarderProperty.class);
+        BuildDiscarderProperty prop = _getProperty(BuildDiscarderProperty.class);
         return prop != null ? prop.getStrategy() : /* settings compatibility */ logRotator;
     }
 
@@ -553,9 +553,13 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
     /**
      * Gets all the job properties configured for this job.
      */
-    @SuppressWarnings("unchecked")
+    @SuppressWarnings({"unchecked", "rawtypes"})
     public Map<JobPropertyDescriptor, JobProperty<? super JobT>> getProperties() {
-        return Descriptor.toMap((Iterable) properties);
+        Map result = Descriptor.toMap((Iterable) properties);
+        if (logRotator != null) {
+            result.put(Jenkins.getActiveInstance().getDescriptorByType(BuildDiscarderProperty.DescriptorImpl.class), new BuildDiscarderProperty(logRotator));
+        }
+        return result;
     }
 
     /**
@@ -572,6 +576,13 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
      * this job.
      */
     public <T extends JobProperty> T getProperty(Class<T> clazz) {
+        if (clazz == BuildDiscarderProperty.class && logRotator != null) {
+            return clazz.cast(new BuildDiscarderProperty(logRotator));
+        }
+        return _getProperty(clazz);
+    }
+
+    private <T extends JobProperty> T _getProperty(Class<T> clazz) {
         for (JobProperty p : properties) {
             if (clazz.isInstance(p))
                 return clazz.cast(p);
@@ -1196,6 +1207,8 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
         try {
             setDisplayName(json.optString("displayNameOrNull"));
 
+            logRotator = null;
+
             DescribableList<JobProperty<?>, JobPropertyDescriptor> t = new DescribableList<JobProperty<?>, JobPropertyDescriptor>(NOOP,getAllProperties());
             JSONObject jsonProperties = json.optJSONObject("properties");
             if (jsonProperties != null) {
diff --git a/test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java b/test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java
index 90c8bf71bd..c137c8bc20 100644
--- a/test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java
+++ b/test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java
@@ -25,6 +25,7 @@
 package jenkins.model;
 
 import hudson.model.AbstractProject;
+import hudson.model.FreeStyleProject;
 import hudson.tasks.LogRotator;
 import java.io.StringReader;
 import javax.xml.transform.Source;
@@ -41,6 +42,29 @@ public class BuildDiscarderPropertyTest {
     @Rule
     public JenkinsRule r = new JenkinsRule();
 
+    @Issue("JENKINS-31518")
+    @LocalData
+    @Test
+    public void buildDiscarderField() throws Exception {
+        FreeStyleProject p = r.jenkins.getItemByFullName("p", FreeStyleProject.class);
+        verifyBuildDiscarder(p);
+        r.configRoundtrip(p);
+        verifyBuildDiscarder(p);
+        String xml = p.getConfigFile().asString();
+        assertFalse(xml, xml.contains("<logRotator class="));
+        assertTrue(xml, xml.contains("<" + BuildDiscarderProperty.class.getName() + ">"));
+    }
+
+    private void verifyBuildDiscarder(FreeStyleProject p) {
+        BuildDiscarder bd = p.getBuildDiscarder();
+        assertNotNull(bd);
+        LogRotator lr = (LogRotator) bd;
+        assertEquals(7, lr.getDaysToKeep());
+        assertEquals(10, lr.getNumToKeep());
+        assertNotNull(p.getProperty(BuildDiscarderProperty.class));
+        assertEquals(1, p.getProperties().size());
+    }
+
     @Issue("JENKINS-16979")
     @LocalData
     @Test
diff --git a/test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/buildDiscarderField.zip b/test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/buildDiscarderField.zip
new file mode 100644
index 0000000000000000000000000000000000000000..fd32a7328236234990664ab48f6f64f5b34f6b54
GIT binary patch
literal 499
zcmWIWW@Zs#U|`^2n9!B$o_SNn+?tVr;RX`}gCK(pLsouLv3`Mma(-S~X1ZQQZcb<j
zCj+xVl3UnTATF)oW?*D_!OXw_CVGQT7adX%x%*pG(mYbK<f@**+|0Row{~r?S~oF9
zc`C!<R=a=u9DI_t8o%xPyo24s;k}*o%)QO73$NPD7rku5e6&<G#P+=T>*FVL>%#k1
zZ2ZN$L)$&lO|tx8k4huggy=-2;Gm+uMOvkMFZEgG8tX|us;T)PniXo%=B_iZx>Dw?
zVPEaTD0{{kpVW@<u9!MC-><@KX^O+zQ)`5O7wkG}U^X-G6ZhZC``;9wdwcqGiC5cd
zl^UKyOgt;JuBbAcww=r|CFbKrnOnvJNe@G$K0RC1e?Y`r|LN<)r+0iUSQa+Rbm?Zh
zBV`()dK2ENgxsBG+xN&Xt8UMCr?A`1D_Z{rywKU87Wgo5_d@&H>xt5z=daKX=P3%i
zQu-rh`RdH0d$%r#F)Fp3USj1K^R@Zd`y~gQ`zP<(dS=G7MN57!zaQYu$Rx*%D;^|(
n@x#CXj24D1jUX15SYd_43R;W=c(byBG%x~TIFN1wnZW=6)E&Zl

literal 0
HcmV?d00001

-- 
GitLab