From 773fdeeb9a7dce92057a376678bb4785b35c0b53 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Wed, 21 Oct 2009 15:28:58 +0000 Subject: [PATCH] avoid instanceof. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22985 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/model/Queue.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/hudson/model/Queue.java b/core/src/main/java/hudson/model/Queue.java index 254a237d0c..78f242282e 100644 --- a/core/src/main/java/hudson/model/Queue.java +++ b/core/src/main/java/hudson/model/Queue.java @@ -443,17 +443,15 @@ public class Queue extends ResourceController implements Saveable { // the requested build is already queued, so will not be added added = null; - List waitingDuplicates = new ArrayList(); for(Item item : duplicatesInQueue) { for(FoldableAction a : Util.filter(actions,FoldableAction.class)) { a.foldIntoExisting(item.task, item.getActions()); } - if ((item instanceof WaitingItem)) - waitingDuplicates.add((WaitingItem)item); } + // TODO: avoid calling scheduleMaintenance() if none of the waiting items // actually change - for(WaitingItem wi : waitingDuplicates) { + for(WaitingItem wi : Util.filter(duplicatesInQueue,WaitingItem.class)) { if(quietPeriod<=0) { // the user really wants to build now, and they mean NOW. // so let's pull in the timestamp if we can. -- GitLab