diff --git a/app/cmd/center.go b/app/cmd/center.go index d88dc64dcbdd559af06d4d44db01985d4fd4c26a..9e2a5088799a78f5fff025698f4ef198e8040de2 100644 --- a/app/cmd/center.go +++ b/app/cmd/center.go @@ -27,7 +27,7 @@ var centerCmd = &cobra.Command{ Use: "center", Short: "Manage your update center", Long: `Manage your update center`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() printJenkinsStatus(jenkins) diff --git a/app/cmd/config.go b/app/cmd/config.go index 5d37a59abb354e85b232e28a848c044bd73ae3f5..348b6161d748023c2c48bf2c88061107f393c3e0 100644 --- a/app/cmd/config.go +++ b/app/cmd/config.go @@ -26,7 +26,7 @@ var configCmd = &cobra.Command{ Aliases: []string{"cfg"}, Short: "Manage the config of jcli", Long: `Manage the config of jcli`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { current := getCurrentJenkins() if current.Description != "" { fmt.Printf("Current Jenkins's name is %s, url is %s, description is %s\n", current.Name, current.URL, current.Description) diff --git a/app/cmd/config_add.go b/app/cmd/config_add.go index d3cf54ab0c24e61506f34207566aaa9a1d4df082..12d00fe4f1303330b09d3c36e1b5df2829ae19a7 100644 --- a/app/cmd/config_add.go +++ b/app/cmd/config_add.go @@ -28,7 +28,7 @@ var configAddCmd = &cobra.Command{ Use: "add", Short: "Add a Jenkins config item", Long: `Add a Jenkins config item`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { if err := addJenkins(configAddOptions.JenkinsServer); err != nil { log.Fatal(err) } diff --git a/app/cmd/config_edit.go b/app/cmd/config_edit.go index 850935dec112ba6c7a7b63f865f5fb622e068606..6a0eece031b5c180e392a743558ecc600f7fabc6 100644 --- a/app/cmd/config_edit.go +++ b/app/cmd/config_edit.go @@ -18,7 +18,7 @@ var configEditCmd = &cobra.Command{ Use: "edit", Short: "Edit a Jenkins config", Long: `Edit a Jenkins config`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { current := getCurrentJenkins() configPath := configOptions.ConfigFileLocation diff --git a/app/cmd/config_generate.go b/app/cmd/config_generate.go index b8e20b5de37a17e14c100e561b8ea9c651d0e469..502c444109ad785ac44c2d1cf987b26f339129fb 100644 --- a/app/cmd/config_generate.go +++ b/app/cmd/config_generate.go @@ -28,7 +28,7 @@ var configGenerateCmd = &cobra.Command{ Aliases: []string{"gen"}, Short: "Generate a sample config file for you", Long: `Generate a sample config file for you`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { if data, err := generateSampleConfig(); err == nil { configPath := configOptions.ConfigFileLocation diff --git a/app/cmd/config_list.go b/app/cmd/config_list.go index 388a10cd77b70a55a4fa5eec520132da700e61dc..3db2bf7961198eddb93685d3ee682a686f6d4881 100644 --- a/app/cmd/config_list.go +++ b/app/cmd/config_list.go @@ -16,7 +16,7 @@ var configListCmd = &cobra.Command{ Use: "list", Short: "List all Jenkins config items", Long: `List all Jenkins config items`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { current := getCurrentJenkins() table := util.CreateTable(os.Stdout) diff --git a/app/cmd/config_remove.go b/app/cmd/config_remove.go index a51ee333fe75b23842419f595eb5003e1b0a0e8b..51e702103157a6a2789cf896959216dee82f849f 100644 --- a/app/cmd/config_remove.go +++ b/app/cmd/config_remove.go @@ -15,7 +15,7 @@ var configRemoveCmd = &cobra.Command{ Use: "remove", Short: "Remove a Jenkins config", Long: `Remove a Jenkins config`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, args []string) { if len(args) == 0 { log.Fatal("You need to give a name") } diff --git a/app/cmd/config_select.go b/app/cmd/config_select.go index 030dd50b14a4a86701704c8794931de72d2617e0..d21c9e916d36bfac5089d686c84667b725563094 100644 --- a/app/cmd/config_select.go +++ b/app/cmd/config_select.go @@ -13,7 +13,7 @@ var configSelectCmd = &cobra.Command{ Use: "select []", Short: "Select one config as current Jenkins", Long: `Select one config as current Jenkins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, args []string) { if len(args) > 0 { jenkinsName := args[0] diff --git a/app/cmd/crumbIssuer.go b/app/cmd/crumbIssuer.go index c98f7ba78afca07a746f2a9200a7445e7b23fab8..ee3a7bf7767dfcc8e8b2fd9ddb8766510d222e66 100644 --- a/app/cmd/crumbIssuer.go +++ b/app/cmd/crumbIssuer.go @@ -28,7 +28,7 @@ var versionCmd = &cobra.Command{ Use: "crumb", Short: "Print crumbIssuer of Jenkins", Long: `Print crumbIssuer of Jenkins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { crumb, _ := getCrumb() fmt.Printf("%s=%s", crumb.CrumbRequestField, crumb.Crumb) }, diff --git a/app/cmd/job.go b/app/cmd/job.go index 38c69f73781aadf9350acadc7303f8cf2e9b1ca6..75e2d2d908fc843ef9c91f0af8cab5b14f1000ca 100644 --- a/app/cmd/job.go +++ b/app/cmd/job.go @@ -19,7 +19,7 @@ var jobCmd = &cobra.Command{ Use: "job", Short: "Print the job of your Jenkins", Long: `Print the job of your Jenkins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(cmd *cobra.Command, _ []string) { cmd.Help() }, } diff --git a/app/cmd/job_type.go b/app/cmd/job_type.go index 39b7e72c4142609ce1017172e4b333fac5278ce1..b3ed5a98851a5ca6a8e42b7552f54b887f3d9ece 100644 --- a/app/cmd/job_type.go +++ b/app/cmd/job_type.go @@ -25,7 +25,7 @@ var jobTypeCmd = &cobra.Command{ Use: "type", Short: "Print the types of job which in your Jenkins", Long: `Print the types of job which in your Jenkins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() jclient := &client.JobClient{} jclient.URL = jenkins.URL diff --git a/app/cmd/open.go b/app/cmd/open.go index 0f3ee2c35625307f9ea3970755a5f62909d595a5..1607486527a9458b5076005e45ec87dca1801339 100644 --- a/app/cmd/open.go +++ b/app/cmd/open.go @@ -30,7 +30,7 @@ var openCmd = &cobra.Command{ Use: "open", Short: "Open your Jenkins with a browse", Long: `Open your Jenkins with a browse`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { var jenkins *JenkinsServer if openOption.Name == "" && openOption.Interactive { diff --git a/app/cmd/plugin.go b/app/cmd/plugin.go index b1af456bdf6ad446046dc29ed72e8b38ac9d0c60..a5e7fbb92ec721d70c518dc29106a13d1975d2b0 100644 --- a/app/cmd/plugin.go +++ b/app/cmd/plugin.go @@ -21,7 +21,7 @@ var pluginCmd = &cobra.Command{ Example: ` jcli plugin list jcli plugin search github jcli plugin check`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(cmd *cobra.Command, _ []string) { cmd.Help() }, } diff --git a/app/cmd/plugin_check.go b/app/cmd/plugin_check.go index 8d73145f87485aeb6c6f2f57e7f0124647ef06ce..b915e700976ac3e4c3e2040f003b52059cddd736 100644 --- a/app/cmd/plugin_check.go +++ b/app/cmd/plugin_check.go @@ -18,7 +18,7 @@ var pluginCheckCmd = &cobra.Command{ Use: "check", Short: "Checkout update center server", Long: `Checkout update center server`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() jclient := &client.PluginManager{} jclient.URL = jenkins.URL diff --git a/app/cmd/plugin_install.go b/app/cmd/plugin_install.go index 89f25f580836c7868e16a72cb8ab8235a1dd7b54..5f51341aa5840137611b71f7c57f5775fde31c8f 100644 --- a/app/cmd/plugin_install.go +++ b/app/cmd/plugin_install.go @@ -17,7 +17,7 @@ var pluginInstallCmd = &cobra.Command{ Use: "install [pluginName]", Short: "Install the plugins", Long: `Install the plugins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, args []string) { jenkins := getCurrentJenkins() jclient := &client.PluginManager{} jclient.URL = jenkins.URL diff --git a/app/cmd/plugin_list.go b/app/cmd/plugin_list.go index 8f9b25049e099a960274fd86cb967cbe1a795724..745925e7c9e76079a608c59de66f6d119b5c2fd3 100644 --- a/app/cmd/plugin_list.go +++ b/app/cmd/plugin_list.go @@ -30,7 +30,7 @@ var pluginListCmd = &cobra.Command{ Long: `Print all the plugins which are installed`, Example: ` jcli plugin list --filter name=github jcli plugin list --filter hasUpdate`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() jclient := &client.PluginManager{} jclient.URL = jenkins.URL diff --git a/app/cmd/plugin_open.go b/app/cmd/plugin_open.go index 41ea2c845489a32b9c0e160eb0d54142b9505c42..3e1704575be3e0e467ef8c5f22f9047e4655704b 100644 --- a/app/cmd/plugin_open.go +++ b/app/cmd/plugin_open.go @@ -15,7 +15,7 @@ var pluginOpenCmd = &cobra.Command{ Use: "open", Short: "Openout update center server", Long: `Openout update center server`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() if jenkins.URL != "" { diff --git a/app/cmd/plugin_upload.go b/app/cmd/plugin_upload.go index 293a43de4ef4f2c6176de8bb34f74fac2db5f020..297d859c5370d087c39f8834c20f8086ba8fb532 100644 --- a/app/cmd/plugin_upload.go +++ b/app/cmd/plugin_upload.go @@ -8,8 +8,8 @@ import ( "path/filepath" "strings" + "github.com/jenkins-zh/jenkins-cli/client" "github.com/jenkins-zh/jenkins-cli/util" - "github.com/jenkins-zh/jenkins-cli/client" "github.com/spf13/cobra" ) @@ -40,7 +40,7 @@ var pluginUploadCmd = &cobra.Command{ Long: `Upload a plugin from local filesystem or remote URL to your Jenkins`, Example: ` jcli plugin upload --remote https://server/sample.hpi jcli plugin upload sample.hpi`, - PreRun: func(cmd *cobra.Command, args []string) { + PreRun: func(_ *cobra.Command, args []string) { if pluginUploadOption.Remote != "" { file, err := ioutil.TempFile(".", "jcli-plugin") if err != nil { @@ -80,7 +80,7 @@ var pluginUploadCmd = &cobra.Command{ pluginUploadOption.pluginFilePath = args[0] } }, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() jclient := &client.PluginManager{} jclient.URL = jenkins.URL diff --git a/app/cmd/queue.go b/app/cmd/queue.go index bb3e6c1b20df9f25d4e4838f7199d0c10056e570..e8e947c571776a0eb9e1d82b1b0e777cee2c041b 100644 --- a/app/cmd/queue.go +++ b/app/cmd/queue.go @@ -23,7 +23,7 @@ var queueCmd = &cobra.Command{ Use: "queue", Short: "Print the queue of your Jenkins", Long: `Print the queue of your Jenkins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() jclient := &client.QueueClient{} jclient.URL = jenkins.URL diff --git a/app/cmd/restart.go b/app/cmd/restart.go index 7240e4d3044dcad4490b8d6f76738741eca3bb29..49b01719edee8019f523aabb8231ed9dab8f8983 100644 --- a/app/cmd/restart.go +++ b/app/cmd/restart.go @@ -24,7 +24,7 @@ var restartCmd = &cobra.Command{ Use: "restart", Short: "Restart your Jenkins", Long: `Restart your Jenkins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() if !restartOption.Batch { confirm := false diff --git a/app/cmd/root.go b/app/cmd/root.go index 59e4939e3cafea08d895e6a34e27625574ed5413..7f6c4d046dafda898158dc86e2e94704350553da 100644 --- a/app/cmd/root.go +++ b/app/cmd/root.go @@ -20,7 +20,7 @@ var rootCmd = &cobra.Command{ Long: `jcli is Jenkins CLI which could help with your multiple Jenkins, Manage your Jenkins and your pipelines More information could found at https://jenkins-zh.cn`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { fmt.Println("Jenkins CLI (jcli) manage your Jenkins") current := getCurrentJenkins() diff --git a/app/cmd/user.go b/app/cmd/user.go index 112cbc7b33bd0196f84b8058d2e7da655398934c..535d3a93f36001a29c5d09774b584f436e7e506f 100644 --- a/app/cmd/user.go +++ b/app/cmd/user.go @@ -23,7 +23,7 @@ var userCmd = &cobra.Command{ Use: "user", Short: "Print the user of your Jenkins", Long: `Print the user of your Jenkins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() jclient := &client.UserClient{} jclient.URL = jenkins.URL diff --git a/app/cmd/user_edit.go b/app/cmd/user_edit.go index ed75778cb84794e547069f693603f9538e8d5ecd..90478d5abff4ba93130a8d3e9c6cef8530911cc3 100644 --- a/app/cmd/user_edit.go +++ b/app/cmd/user_edit.go @@ -23,7 +23,7 @@ var userEditCmd = &cobra.Command{ Use: "edit", Short: "Edit the user of your Jenkins", Long: `Edit the user of your Jenkins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(_ *cobra.Command, _ []string) { jenkins := getCurrentJenkins() jclient := &client.UserClient{} jclient.URL = jenkins.URL diff --git a/app/cmd/user_token.go b/app/cmd/user_token.go index f1cf3535c251c881247503fe92a77d7b7e486a75..663c27e8f0080322b5f59e099a6e990797cf9cf0 100644 --- a/app/cmd/user_token.go +++ b/app/cmd/user_token.go @@ -25,7 +25,7 @@ var userTokenCmd = &cobra.Command{ Use: "token", Short: "Token the user of your Jenkins", Long: `Token the user of your Jenkins`, - Run: func(cmd *cobra.Command, args []string) { + Run: func(cmd *cobra.Command, _ []string) { if !userTokenOption.Generate { cmd.Help() return diff --git a/client/user.go b/client/user.go index 00cf1155a48a5503c75e569183fd5396b82e8c25..e5738aa507aae5bf59d16036d77dffd8805c3b43 100644 --- a/client/user.go +++ b/client/user.go @@ -89,8 +89,7 @@ func (q *UserClient) EditDesc(description string) (err error) { code := response.StatusCode var data []byte data, err = ioutil.ReadAll(response.Body) - if code == 200 { - } else { + if code != 200 { log.Fatal(string(data)) } } else { diff --git a/util/http.go b/util/http.go index 028df5d01ac6832e8e41ee748f266517636c5a6c..2b3e1c379c9c6cb1a8f85ff83b5e780e7388d25d 100644 --- a/util/http.go +++ b/util/http.go @@ -107,7 +107,7 @@ func (i *ProgressIndicator) Init() { // i.bar.PrependElapsed() if i.Title != "" { - i.bar.PrependFunc(func(b *uiprogress.Bar) string { + i.bar.PrependFunc(func(_ *uiprogress.Bar) string { return fmt.Sprintf("%s: ", i.Title) }) }