Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
六月暴雪飞梨花
soar
提交
b57106b5
S
soar
项目概览
六月暴雪飞梨花
/
soar
与 Fork 源项目一致
Fork自
Xiaomi / soar
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
soar
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b57106b5
编写于
1月 08, 2019
作者:
martianzhang
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fix #173 with JSONFind
WHERE col = col = '' and col1 = 'xx'
上级
26574fea
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
14 addition
and
31 deletion
+14
-31
advisor/heuristic.go
advisor/heuristic.go
+11
-31
advisor/heuristic_test.go
advisor/heuristic_test.go
+3
-0
未找到文件。
advisor/heuristic.go
浏览文件 @
b57106b5
...
@@ -31,6 +31,7 @@ import (
...
@@ -31,6 +31,7 @@ import (
"github.com/percona/go-mysql/query"
"github.com/percona/go-mysql/query"
tidb
"github.com/pingcap/parser/ast"
tidb
"github.com/pingcap/parser/ast"
"github.com/pingcap/parser/mysql"
"github.com/pingcap/parser/mysql"
"github.com/tidwall/gjson"
"vitess.io/vitess/go/vt/sqlparser"
"vitess.io/vitess/go/vt/sqlparser"
)
)
...
@@ -1312,37 +1313,16 @@ func (q *Query4Audit) RuleLoadFile() Rule {
...
@@ -1312,37 +1313,16 @@ func (q *Query4Audit) RuleLoadFile() Rule {
func
(
q
*
Query4Audit
)
RuleMultiCompare
()
Rule
{
func
(
q
*
Query4Audit
)
RuleMultiCompare
()
Rule
{
var
rule
=
q
.
RuleOK
()
var
rule
=
q
.
RuleOK
()
if
q
.
TiStmt
!=
nil
{
if
q
.
TiStmt
!=
nil
{
for
_
,
tiStmt
:=
range
q
.
TiStmt
{
json
:=
ast
.
StmtNode2JSON
(
q
.
Query
,
""
,
""
)
switch
node
:=
tiStmt
.
(
type
)
{
whereJSON
:=
common
.
JSONFind
(
json
,
"Where"
)
case
*
tidb
.
SelectStmt
:
for
_
,
where
:=
range
whereJSON
{
switch
where
:=
node
.
Where
.
(
type
)
{
conds
:=
[]
string
{
where
}
case
*
tidb
.
BinaryOperationExpr
:
conds
=
append
(
conds
,
common
.
JSONFind
(
where
,
"L"
)
...
)
switch
where
.
L
.
(
type
)
{
conds
=
append
(
conds
,
common
.
JSONFind
(
where
,
"R"
)
...
)
case
*
tidb
.
BinaryOperationExpr
:
for
_
,
cond
:=
range
conds
{
if
where
.
Op
.
String
()
==
"eq"
{
if
gjson
.
Get
(
cond
,
"Op"
)
.
Int
()
==
7
&&
gjson
.
Get
(
cond
,
"L.Op"
)
.
Int
()
==
7
{
rule
=
HeuristicRules
[
"RES.009"
]
rule
=
HeuristicRules
[
"RES.009"
]
}
return
rule
}
}
case
*
tidb
.
UpdateStmt
:
switch
where
:=
node
.
Where
.
(
type
)
{
case
*
tidb
.
BinaryOperationExpr
:
switch
where
.
L
.
(
type
)
{
case
*
tidb
.
BinaryOperationExpr
:
if
where
.
Op
.
String
()
==
"eq"
{
rule
=
HeuristicRules
[
"RES.009"
]
}
}
}
case
*
tidb
.
DeleteStmt
:
switch
where
:=
node
.
Where
.
(
type
)
{
case
*
tidb
.
BinaryOperationExpr
:
switch
where
.
L
.
(
type
)
{
case
*
tidb
.
BinaryOperationExpr
:
if
where
.
Op
.
String
()
==
"eq"
{
rule
=
HeuristicRules
[
"RES.009"
]
}
}
}
}
}
}
}
}
...
...
advisor/heuristic_test.go
浏览文件 @
b57106b5
...
@@ -946,6 +946,9 @@ func TestRuleMultiCompare(t *testing.T) {
...
@@ -946,6 +946,9 @@ func TestRuleMultiCompare(t *testing.T) {
sqls
:=
[][]
string
{
sqls
:=
[][]
string
{
{
{
"SELECT * FROM tbl WHERE col = col = 'abc'"
,
"SELECT * FROM tbl WHERE col = col = 'abc'"
,
"SELECT * FROM tbl WHERE col = 'def' and col = col = 'abc'"
,
"SELECT * FROM tbl WHERE col = 'def' or col = col = 'abc'"
,
"SELECT * FROM tbl WHERE col = col = 'abc' and col = 'def'"
,
"UPDATE tbl set col = 1 WHERE col = col = 'abc'"
,
"UPDATE tbl set col = 1 WHERE col = col = 'abc'"
,
"DELETE FROM tbl WHERE col = col = 'abc'"
,
"DELETE FROM tbl WHERE col = col = 'abc'"
,
},
},
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录