From d706a714f50b5745caea52464f4c95e0afd61572 Mon Sep 17 00:00:00 2001
From: Huan LI <zixia@zixia.net>
Date: Wed, 1 Mar 2017 16:55:54 +0800
Subject: [PATCH] fix(room): do not permit undefined param

---
 src/room.ts | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/room.ts b/src/room.ts
index b4c68e4c..99e3b954 100644
--- a/src/room.ts
+++ b/src/room.ts
@@ -88,12 +88,10 @@ export class Room extends EventEmitter implements Sayable {
     return
   }
 
-  private async readyAllMembers(memberList?: RoomRawMember[]): Promise<void> {
-    if (memberList) {
-      for (let member of memberList) {
-        let contact = Contact.load(member.UserName)
-        await contact.ready()
-      }
+  private async readyAllMembers(memberList: RoomRawMember[]): Promise<void> {
+    for (let member of memberList) {
+      let contact = Contact.load(member.UserName)
+      await contact.ready()
     }
     return
   }
@@ -122,7 +120,7 @@ export class Room extends EventEmitter implements Sayable {
       const data = await contactGetter(this.id)
       log.silly('Room', `contactGetter(${this.id}) resolved`)
       this.rawObj = data
-      await this.readyAllMembers(this.rawObj.MemberList)
+      await this.readyAllMembers(this.rawObj.MemberList || [])
       this.obj    = this.parse(this.rawObj)
       if (!this.obj) {
         throw new Error('no this.obj set after contactGetter')
-- 
GitLab