From 83b1a8f6bf295fefcf44949d17b538de47eb522e Mon Sep 17 00:00:00 2001
From: Abhinav Arora <abhinavarora28@gmail.com>
Date: Thu, 26 Apr 2018 15:29:33 -0700
Subject: [PATCH] Pending more CPPLint errors in fluid/operators/math (#10243)

* Fix CPPLint issue in test_engine

* Fix CPPLint errors in operators/math

* Fix compilation
---
 paddle/fluid/inference/engine.h                      | 1 -
 paddle/fluid/inference/tensorrt/engine.h             | 6 ++++--
 paddle/fluid/inference/tensorrt/test_engine.cc       | 6 +++---
 paddle/fluid/operators/concurrency/channel_util.cc   | 2 +-
 paddle/fluid/operators/math/context_project.h        | 2 ++
 paddle/fluid/operators/math/im2col.cc                | 1 +
 paddle/fluid/operators/math/im2col.cu                | 2 ++
 paddle/fluid/operators/math/im2col.h                 | 1 +
 paddle/fluid/operators/math/math_function_impl.h     | 1 +
 paddle/fluid/operators/math/sequence_padding_test.cc | 3 ++-
 paddle/fluid/operators/math/sequence_pooling.cu      | 1 +
 paddle/fluid/operators/math/sequence_pooling.h       | 1 +
 paddle/fluid/operators/math/vol2col.h                | 1 +
 paddle/fluid/operators/reader/reader_op_registry.h   | 2 ++
 14 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/paddle/fluid/inference/engine.h b/paddle/fluid/inference/engine.h
index 0633c052e4d..6b0ac92fa90 100644
--- a/paddle/fluid/inference/engine.h
+++ b/paddle/fluid/inference/engine.h
@@ -46,7 +46,6 @@ class EngineBase {
   virtual void Execute(int batch_size) = 0;
 
   virtual ~EngineBase() {}
-
 };  // class EngineBase
 
 }  // namespace inference
diff --git a/paddle/fluid/inference/tensorrt/engine.h b/paddle/fluid/inference/tensorrt/engine.h
index ff853455b8b..82d8c3df4ec 100644
--- a/paddle/fluid/inference/tensorrt/engine.h
+++ b/paddle/fluid/inference/tensorrt/engine.h
@@ -16,7 +16,9 @@ limitations under the License. */
 
 #include <NvInfer.h>
 #include <memory>
+#include <string>
 #include <unordered_map>
+#include <vector>
 #include "paddle/fluid/inference/engine.h"
 #include "paddle/fluid/inference/tensorrt/helper.h"
 
@@ -56,9 +58,9 @@ class TensorRTEngine : public EngineBase {
   virtual ~TensorRTEngine();
 
   // TODO(Superjomn) implement it later when graph segmentation is supported.
-  virtual void Build(const DescType& paddle_model) override;
+  void Build(const DescType& paddle_model) override;
 
-  virtual void Execute(int batch_size) override;
+  void Execute(int batch_size) override;
 
   // Initialize the inference network, so that TensorRT layers can add to this
   // network.
diff --git a/paddle/fluid/inference/tensorrt/test_engine.cc b/paddle/fluid/inference/tensorrt/test_engine.cc
index f3dbdf11f21..c6e1c71cdc8 100644
--- a/paddle/fluid/inference/tensorrt/test_engine.cc
+++ b/paddle/fluid/inference/tensorrt/test_engine.cc
@@ -12,13 +12,12 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License. */
 
-#include "paddle/fluid/inference/tensorrt/engine.h"
-
 #include <cuda.h>
 #include <cuda_runtime_api.h>
 #include <glog/logging.h>
 #include <gtest/gtest.h>
 
+#include "paddle/fluid/inference/tensorrt/engine.h"
 #include "paddle/fluid/platform/enforce.h"
 
 namespace paddle {
@@ -65,7 +64,8 @@ TEST_F(TensorRTEngineTest, add_layer) {
 
   // fill in real data
   float x_v = 1234;
-  engine_->SetInputFromCPU("x", (void*)&x_v, 1 * sizeof(float));
+  engine_->SetInputFromCPU("x", reinterpret_cast<void*>(&x_v),
+                           1 * sizeof(float));
   LOG(INFO) << "to execute";
   engine_->Execute(1);
 
diff --git a/paddle/fluid/operators/concurrency/channel_util.cc b/paddle/fluid/operators/concurrency/channel_util.cc
index 246c99489c4..fba4abf1897 100644
--- a/paddle/fluid/operators/concurrency/channel_util.cc
+++ b/paddle/fluid/operators/concurrency/channel_util.cc
@@ -12,7 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License. */
 
-#include "channel_util.h"
+#include "paddle/fluid/operators/concurrency/channel_util.h"
 #include "paddle/fluid/framework/var_type.h"
 
 namespace poc = paddle::operators::concurrency;
diff --git a/paddle/fluid/operators/math/context_project.h b/paddle/fluid/operators/math/context_project.h
index 4da94383af6..027a019a284 100644
--- a/paddle/fluid/operators/math/context_project.h
+++ b/paddle/fluid/operators/math/context_project.h
@@ -14,6 +14,8 @@ limitations under the License. */
 
 #pragma once
 
+#include <algorithm>
+#include <vector>
 #include "paddle/fluid/framework/lod_tensor.h"
 #include "paddle/fluid/operators/math/im2col.h"
 #include "paddle/fluid/operators/math/math_function.h"
diff --git a/paddle/fluid/operators/math/im2col.cc b/paddle/fluid/operators/math/im2col.cc
index 123e10586f6..336d6febc2c 100644
--- a/paddle/fluid/operators/math/im2col.cc
+++ b/paddle/fluid/operators/math/im2col.cc
@@ -13,6 +13,7 @@ See the License for the specific language governing permissions and
 limitations under the License. */
 
 #include "paddle/fluid/operators/math/im2col.h"
+#include <vector>
 
 namespace paddle {
 namespace operators {
diff --git a/paddle/fluid/operators/math/im2col.cu b/paddle/fluid/operators/math/im2col.cu
index f41c78140fb..1268e21e060 100644
--- a/paddle/fluid/operators/math/im2col.cu
+++ b/paddle/fluid/operators/math/im2col.cu
@@ -12,6 +12,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License. */
 
+#include <algorithm>
+#include <vector>
 #include "paddle/fluid/operators/math/im2col.h"
 #include "paddle/fluid/platform/cuda_helper.h"
 
diff --git a/paddle/fluid/operators/math/im2col.h b/paddle/fluid/operators/math/im2col.h
index 451ec9d5349..26d94e0f2e6 100644
--- a/paddle/fluid/operators/math/im2col.h
+++ b/paddle/fluid/operators/math/im2col.h
@@ -14,6 +14,7 @@ limitations under the License. */
 
 #pragma once
 
+#include <vector>
 #include "paddle/fluid/framework/tensor.h"
 #include "paddle/fluid/framework/tensor_util.h"
 #include "paddle/fluid/platform/device_context.h"
diff --git a/paddle/fluid/operators/math/math_function_impl.h b/paddle/fluid/operators/math/math_function_impl.h
index f9d4e453242..b9bd49d77d9 100644
--- a/paddle/fluid/operators/math/math_function_impl.h
+++ b/paddle/fluid/operators/math/math_function_impl.h
@@ -13,6 +13,7 @@ See the License for the specific language governing permissions and
 limitations under the License. */
 
 #pragma once
+#include <vector>
 #include "paddle/fluid/framework/data_type.h"
 #include "paddle/fluid/operators/math/math_function.h"
 
diff --git a/paddle/fluid/operators/math/sequence_padding_test.cc b/paddle/fluid/operators/math/sequence_padding_test.cc
index bece46e7537..e3d62144856 100644
--- a/paddle/fluid/operators/math/sequence_padding_test.cc
+++ b/paddle/fluid/operators/math/sequence_padding_test.cc
@@ -14,6 +14,7 @@ limitations under the License. */
 
 #include "paddle/fluid/operators/math/sequence_padding.h"
 #include <gtest/gtest.h>
+#include <vector>
 
 template <typename DeviceContext, typename Place, typename T>
 void TestSequencePadding(const paddle::framework::LoD& lod,
@@ -75,7 +76,7 @@ void TestSequencePadding(const paddle::framework::LoD& lod,
 
   delete place;
   delete context;
-};
+}
 
 TEST(Seq2BatchPadding, CPU) {
   paddle::framework::LoD lod1;
diff --git a/paddle/fluid/operators/math/sequence_pooling.cu b/paddle/fluid/operators/math/sequence_pooling.cu
index 1935364da37..36f64023963 100644
--- a/paddle/fluid/operators/math/sequence_pooling.cu
+++ b/paddle/fluid/operators/math/sequence_pooling.cu
@@ -12,6 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License. */
 
+#include <string>
 #include "paddle/fluid/operators/math/math_function.h"
 #include "paddle/fluid/operators/math/sequence_pooling.h"
 #include "paddle/fluid/platform/cuda_helper.h"
diff --git a/paddle/fluid/operators/math/sequence_pooling.h b/paddle/fluid/operators/math/sequence_pooling.h
index 38e78022295..8dcbee65d0b 100644
--- a/paddle/fluid/operators/math/sequence_pooling.h
+++ b/paddle/fluid/operators/math/sequence_pooling.h
@@ -13,6 +13,7 @@ See the License for the specific language governing permissions and
 limitations under the License. */
 
 #pragma once
+#include <string>
 #include "paddle/fluid/framework/lod_tensor.h"
 #include "paddle/fluid/framework/tensor.h"
 #include "paddle/fluid/platform/device_context.h"
diff --git a/paddle/fluid/operators/math/vol2col.h b/paddle/fluid/operators/math/vol2col.h
index dbc2ed7a693..5f59de8f02a 100644
--- a/paddle/fluid/operators/math/vol2col.h
+++ b/paddle/fluid/operators/math/vol2col.h
@@ -14,6 +14,7 @@ limitations under the License. */
 
 #pragma once
 
+#include <vector>
 #include "paddle/fluid/framework/tensor.h"
 #include "paddle/fluid/framework/tensor_util.h"
 #include "paddle/fluid/platform/device_context.h"
diff --git a/paddle/fluid/operators/reader/reader_op_registry.h b/paddle/fluid/operators/reader/reader_op_registry.h
index 929d32ad8b3..ec25f55ef5c 100644
--- a/paddle/fluid/operators/reader/reader_op_registry.h
+++ b/paddle/fluid/operators/reader/reader_op_registry.h
@@ -14,6 +14,8 @@
 
 #pragma once
 
+#include <string>
+#include <vector>
 #include "paddle/fluid/framework/op_registry.h"
 #include "paddle/fluid/framework/reader.h"
 
-- 
GitLab