From 1102591595885bcd61a1041bc341e0c398bd21db Mon Sep 17 00:00:00 2001 From: qiaolongfei Date: Wed, 20 Dec 2017 17:22:38 +0800 Subject: [PATCH] add two sub title --- doc/design/kernel_hint_design.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/design/kernel_hint_design.md b/doc/design/kernel_hint_design.md index 1ccab168449..75f0e4ea727 100644 --- a/doc/design/kernel_hint_design.md +++ b/doc/design/kernel_hint_design.md @@ -19,11 +19,13 @@ so, we should send the information user defined in proto to `GetExpectedKernelTy The problem is, how should we define and send the information for `GetExpectedKernelType` to use? ## Solution + +### potential choice 1, Do nothing, let the user add the information they want to operator‘s attribute and get them inside `GetExpectedKernelType`, this can work right. But there is a little problem that users may define many kinds of hints for the same purpose, such as `force_cpu`, `use_cpu`, `CPU` for CPU kernel, and `use_cudnn`, `force_cudnn`, `cudnn_kernel` for use of CUDNN kernel. 2, Pre-define all the needed option and use a single attr key such as `kernel_hint` for the user, this is not so flexible if the user wants to define some more kind of hint. - +### final choice To provide enough flexibility while avoiding confusion definition, we can predefine some options, such as `force_cpu`, `use_cudnn`, `use_mkldnn` for a user to choose. ```cpp -- GitLab