diff --git a/cpp/src/db/DB.cpp b/cpp/src/db/DB.cpp
index 1365d4e116ed00859e473fd139f1ea6a1fbc0d01..3b4f03d247da8bea5b6641d351baadbc6fb6fecf 100644
--- a/cpp/src/db/DB.cpp
+++ b/cpp/src/db/DB.cpp
@@ -12,6 +12,8 @@ namespace zilliz {
namespace milvus {
namespace engine {
+DB::~DB() = default;
+
void DB::Open(const Options& options, DB** dbptr) {
*dbptr = DBFactory::Build(options);
}
diff --git a/cpp/src/db/IDGenerator.cpp b/cpp/src/db/IDGenerator.cpp
index 70d71817fcb7488cac13098beee4d73b99fbd3b1..74d3a1433aff57a5b2ffe458979baf96810140b6 100644
--- a/cpp/src/db/IDGenerator.cpp
+++ b/cpp/src/db/IDGenerator.cpp
@@ -13,6 +13,8 @@ namespace zilliz {
namespace milvus {
namespace engine {
+IDGenerator::~IDGenerator() = default;
+
constexpr size_t SimpleIDGenerator::MAX_IDS_PER_MICRO;
IDNumber SimpleIDGenerator::GetNextIDNumber() {
diff --git a/cpp/src/db/IDGenerator.h b/cpp/src/db/IDGenerator.h
index 502b2865f1d764195c106953c079e2966a64c854..eb39221734671922b3105286652856f953efc039 100644
--- a/cpp/src/db/IDGenerator.h
+++ b/cpp/src/db/IDGenerator.h
@@ -17,9 +17,14 @@ namespace engine {
class IDGenerator {
public:
- virtual IDNumber GetNextIDNumber() = 0;
- virtual void GetNextIDNumbers(size_t n, IDNumbers &ids) = 0;
- virtual ~IDGenerator() = 0;
+ virtual
+ IDNumber GetNextIDNumber() = 0;
+
+ virtual void
+ GetNextIDNumbers(size_t n, IDNumbers &ids) = 0;
+
+ virtual
+ ~IDGenerator() = 0;
}; // IDGenerator
diff --git a/cpp/src/db/Meta.cpp b/cpp/src/db/Meta.cpp
index cc7525528f61ce53711ec114f65dbc540d70d60a..a86051a1c483c4edcaee42e20d4ad840e3de6a2a 100644
--- a/cpp/src/db/Meta.cpp
+++ b/cpp/src/db/Meta.cpp
@@ -13,6 +13,8 @@ namespace milvus {
namespace engine {
namespace meta {
+Meta::~Meta() = default;
+
DateT Meta::GetDate(const std::time_t& t, int day_delta) {
struct tm ltm;
localtime_r(&t, <m);
diff --git a/cpp/src/db/Meta.h b/cpp/src/db/Meta.h
index b18cea35e114656081c5cf7e42178db040d0856a..5275605611271e2b453757cea6a0905b3ecdffb0 100644
--- a/cpp/src/db/Meta.h
+++ b/cpp/src/db/Meta.h
@@ -20,57 +20,86 @@ namespace meta {
class Meta {
-public:
+ public:
using Ptr = std::shared_ptr;
- virtual ~Meta() = 0;
- virtual Status CreateTable(TableSchema& table_schema) = 0;
- virtual Status DescribeTable(TableSchema& table_schema) = 0;
- virtual Status HasTable(const std::string& table_id, bool& has_or_not) = 0;
- virtual Status AllTables(std::vector& table_schema_array) = 0;
+ virtual
+ ~Meta() = 0;
- virtual Status DeleteTable(const std::string& table_id) = 0;
- virtual Status DeleteTableFiles(const std::string& table_id) = 0;
+ virtual Status
+ CreateTable(TableSchema &table_schema) = 0;
- virtual Status CreateTableFile(TableFileSchema& file_schema) = 0;
- virtual Status DropPartitionsByDates(const std::string& table_id,
- const DatesT& dates) = 0;
+ virtual Status
+ DescribeTable(TableSchema &table_schema) = 0;
- virtual Status GetTableFiles(const std::string& table_id,
- const std::vector& ids,
- TableFilesSchema& table_files) = 0;
+ virtual Status
+ HasTable(const std::string &table_id, bool &has_or_not) = 0;
- virtual Status UpdateTableFilesToIndex(const std::string& table_id) = 0;
+ virtual Status
+ AllTables(std::vector &table_schema_array) = 0;
- virtual Status UpdateTableFile(TableFileSchema& file_schema) = 0;
+ virtual Status
+ DeleteTable(const std::string &table_id) = 0;
- virtual Status UpdateTableFiles(TableFilesSchema& files) = 0;
+ virtual Status
+ DeleteTableFiles(const std::string &table_id) = 0;
- virtual Status FilesToSearch(const std::string &table_id,
- const DatesT &partition,
- DatePartionedTableFilesSchema& files) = 0;
+ virtual Status
+ CreateTableFile(TableFileSchema &file_schema) = 0;
- virtual Status FilesToMerge(const std::string& table_id,
- DatePartionedTableFilesSchema& files) = 0;
+ virtual Status
+ DropPartitionsByDates(const std::string &table_id, const DatesT &dates) = 0;
- virtual Status Size(uint64_t& result) = 0;
+ virtual Status
+ GetTableFiles(const std::string &table_id, const std::vector &ids, TableFilesSchema &table_files) = 0;
- virtual Status Archive() = 0;
+ virtual Status
+ UpdateTableFilesToIndex(const std::string &table_id) = 0;
- virtual Status FilesToIndex(TableFilesSchema&) = 0;
+ virtual Status
+ UpdateTableFile(TableFileSchema &file_schema) = 0;
- virtual Status HasNonIndexFiles(const std::string& table_id, bool& has) = 0;
+ virtual Status
+ UpdateTableFiles(TableFilesSchema &files) = 0;
- virtual Status CleanUp() = 0;
- virtual Status CleanUpFilesWithTTL(uint16_t) = 0;
+ virtual Status
+ FilesToSearch(const std::string &table_id, const DatesT &partition, DatePartionedTableFilesSchema &files) = 0;
- virtual Status DropAll() = 0;
+ virtual Status
+ FilesToMerge(const std::string &table_id, DatePartionedTableFilesSchema &files) = 0;
- virtual Status Count(const std::string& table_id, uint64_t& result) = 0;
+ virtual Status
+ Size(uint64_t &result) = 0;
- static DateT GetDate(const std::time_t& t, int day_delta = 0);
- static DateT GetDate();
- static DateT GetDateWithDelta(int day_delta);
+ virtual Status
+ Archive() = 0;
+
+ virtual Status
+ FilesToIndex(TableFilesSchema &) = 0;
+
+ virtual Status
+ HasNonIndexFiles(const std::string &table_id, bool &has) = 0;
+
+ virtual Status
+ CleanUp() = 0;
+
+ virtual Status
+ CleanUpFilesWithTTL(uint16_t) = 0;
+
+ virtual Status
+ DropAll() = 0;
+
+ virtual Status
+ Count(const std::string &table_id, uint64_t &result) = 0;
+
+ static DateT
+ GetDate(const std::time_t &t, int day_delta = 0);
+
+ static DateT
+ GetDate();
+
+ static DateT
+ GetDateWithDelta(int day_delta);
}; // MetaData