From ce7de0941f7a0864eef1673e9906218becdf7034 Mon Sep 17 00:00:00 2001 From: starlord Date: Fri, 6 Sep 2019 14:39:26 +0800 Subject: [PATCH] MS-492 Drop index failed if index have been created with index_type: FLAT Former-commit-id: 6451e083ad60c076e98d063662a914f09832abfc --- cpp/CHANGELOG.md | 1 + cpp/src/server/grpc_impl/GrpcRequestTask.cpp | 11 ++--------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/cpp/CHANGELOG.md b/cpp/CHANGELOG.md index d599b525..af32680e 100644 --- a/cpp/CHANGELOG.md +++ b/cpp/CHANGELOG.md @@ -26,6 +26,7 @@ Please mark all change in change log and use the ticket from JIRA. - MS-467 - mysql db test failed - MS-470 - Drop index success, which table not created - MS-471 - code coverage run failed +- MS-492 - Drop index failed if index have been created with index_type: FLAT ## Improvement - MS-327 - Clean code for milvus diff --git a/cpp/src/server/grpc_impl/GrpcRequestTask.cpp b/cpp/src/server/grpc_impl/GrpcRequestTask.cpp index e0529c19..4bbc15f8 100644 --- a/cpp/src/server/grpc_impl/GrpcRequestTask.cpp +++ b/cpp/src/server/grpc_impl/GrpcRequestTask.cpp @@ -955,15 +955,8 @@ DropIndexTask::OnExecute() { return SetError(res, "Invalid table name: " + table_name_); } - //step 2:check index existence - engine::TableIndex index; - engine::Status stat = DBWrapper::DB()->DescribeIndex(table_name_, index); - if (index.engine_type_ == 1) { - return SetError(SERVER_UNEXPECTED_ERROR, "index not existed"); - } - - //step 3: check table existence - stat = DBWrapper::DB()->DropIndex(table_name_); + //step 2: check table existence + auto stat = DBWrapper::DB()->DropIndex(table_name_); if (!stat.ok()) { return SetError(DB_META_TRANSACTION_FAILED, stat.ToString()); } -- GitLab