diff --git a/cpp/CHANGELOG.md b/cpp/CHANGELOG.md index c0dedf4aff2b0acee095e967e8d699a9f0c2e3c1..aff760ebecfa9d9d895a738425a048f8a183d029 100644 --- a/cpp/CHANGELOG.md +++ b/cpp/CHANGELOG.md @@ -5,6 +5,7 @@ Please mark all change in change log and use the ticket from JIRA. # Milvus 0.4.0 (2019-07-28) ## Bug +- MS-119 - The problem of combining the log files - MS-411 - Fix metric unittest linking error - MS-412 - Fix gpu cache logical error - MS-416 - ExecutionEngineImpl::GpuCache has not return value cause crash @@ -30,7 +31,7 @@ Please mark all change in change log and use the ticket from JIRA. - MS-493 - Knowhere unittest crash - MS-453 - GPU search error when nprobe set more than 1024 - MS-510 - unittest out of memory and crashed -- MS-119 - The problem of combining the log files +- MS-507 - Dataset 10m-512, index type sq8,performance in-normal when set CPU_CACHE to 16 or 64 ## Improvement - MS-327 - Clean code for milvus diff --git a/cpp/src/db/engine/ExecutionEngineImpl.cpp b/cpp/src/db/engine/ExecutionEngineImpl.cpp index 9f0b825b93ce06852062afb9af131aa34c71972f..45bc0d0ecdd295843e61f986f80b56f4e2a24ff9 100644 --- a/cpp/src/db/engine/ExecutionEngineImpl.cpp +++ b/cpp/src/db/engine/ExecutionEngineImpl.cpp @@ -303,13 +303,15 @@ Status ExecutionEngineImpl::Search(long n, } Status ExecutionEngineImpl::Cache() { - zilliz::milvus::cache::CpuCacheMgr::GetInstance()->InsertItem(location_, index_); + cache::DataObjPtr obj = std::make_shared(index_, PhysicalSize()); + zilliz::milvus::cache::CpuCacheMgr::GetInstance()->InsertItem(location_, obj); return Status::OK(); } Status ExecutionEngineImpl::GpuCache(uint64_t gpu_id) { - zilliz::milvus::cache::GpuCacheMgr::GetInstance(gpu_id)->InsertItem(location_, index_); + cache::DataObjPtr obj = std::make_shared(index_, PhysicalSize()); + zilliz::milvus::cache::GpuCacheMgr::GetInstance(gpu_id)->InsertItem(location_, obj); return Status::OK(); }