From df144e21884093f877f542bf4e5d48b56c0768f3 Mon Sep 17 00:00:00 2001 From: HappyAngel Date: Wed, 19 Feb 2020 15:46:19 +0800 Subject: [PATCH] add no_check_list for no_grad_set rule (#22571) --- .../tests/unittests/white_list/no_grad_set_white_list.py | 4 ++-- tools/check_api_approvals.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/python/paddle/fluid/tests/unittests/white_list/no_grad_set_white_list.py b/python/paddle/fluid/tests/unittests/white_list/no_grad_set_white_list.py index 572beefaa0..29eeb590f6 100644 --- a/python/paddle/fluid/tests/unittests/white_list/no_grad_set_white_list.py +++ b/python/paddle/fluid/tests/unittests/white_list/no_grad_set_white_list.py @@ -13,7 +13,8 @@ # limitations under the License. # check no_grad_set is None -NOT_CHECK_OP_LIST = [] +NOT_CHECK_OP_LIST = ['deformable_conv'] + # TODO(Shixiaowei02): Check if the items do not need fix. # no_grad_set has value in NEED_TO_FIX_OP_LIST # yapf: disable @@ -31,7 +32,6 @@ NEED_TO_FIX_OP_LIST = [ 'cross_entropy', 'cross_entropy2', 'data_norm', - 'deformable_conv', 'deformable_conv_v1', 'depthwise_conv2d', 'depthwise_conv2d_transpose', diff --git a/tools/check_api_approvals.sh b/tools/check_api_approvals.sh index 8743a3de43..068966c683 100644 --- a/tools/check_api_approvals.sh +++ b/tools/check_api_approvals.sh @@ -132,7 +132,7 @@ for API_FILE in ${API_FILES[*]}; do echo_line="You must have one RD (songyouwei, luotao1 or phlrain) approval for ${API_FILE}, which manages the white list of batch size 1 input for sequence op test. For more information, please refer to [https://github.com/PaddlePaddle/Paddle/wiki/It-is-required-to-include-LoDTensor-input-with-batch_size=1-in-sequence-OP-test]. \n" check_approval 1 2573291 6836917 43953930 elif [ "${API_FILE}" == "python/paddle/fluid/tests/unittests/white_list/no_grad_set_white_list.py" ];then - echo_line="You must have one RD (Shixiaowei02 (Recommend), luotao1 or phlrain) approval for the python/paddle/fluid/tests/unittests/white_list/no_grad_set_white_list.py, which manages the white list of no_grad_set without value in operators.\n" + echo_line="You must have one RD (Shixiaowei02 (Recommend), luotao1 or phlrain) approval for the python/paddle/fluid/tests/unittests/white_list/no_grad_set_white_list.py, which manages the white list of no_grad_set without value in operators. For more information, please refer to[https://github.com/PaddlePaddle/Paddle/wiki/It's-recommend-to-set-no_grad_set-to-be-None].\n" check_approval 1 39303645 6836917 43953930 else echo_line="You must have one RD (XiaoguangHu01,Xreki,luotao1,sneaxiy) approval for ${API_FILE}, which manages the underlying code for fluid.\n" -- GitLab