From 96add8a4698e459a60aa3d2dab173c8a22d9495c Mon Sep 17 00:00:00 2001
From: Zeng Jinle <32832641+sneaxiy@users.noreply.github.com>
Date: Mon, 13 Apr 2020 15:21:43 +0800
Subject: [PATCH] fix print_signatures.py when defaults=None, test=develop,
 test=document_fix (#23784)

---
 tools/print_signatures.py | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/tools/print_signatures.py b/tools/print_signatures.py
index 19378d50f8..efb925a5a9 100644
--- a/tools/print_signatures.py
+++ b/tools/print_signatures.py
@@ -53,19 +53,23 @@ def get_functools_partial_spec(func):
     return '{}(args={}, keywords={})'.format(func_str, args, keywords)
 
 
-def format_spec_doc(spec, doc=None):
+def format_spec(spec):
     args = spec.args
     varargs = spec.varargs
     keywords = spec.keywords
-    defaults = list(spec.defaults)
-    for idx, item in enumerate(defaults):
-        if not isinstance(item, functools.partial):
-            continue
+    defaults = spec.defaults
+    if defaults is not None:
+        defaults = list(defaults)
+        for idx, item in enumerate(defaults):
+            if not isinstance(item, functools.partial):
+                continue
+
+            defaults[idx] = get_functools_partial_spec(item)
 
-        defaults[idx] = get_functools_partial_spec(item)
+        defaults = tuple(defaults)
 
     return 'ArgSpec(args={}, varargs={}, keywords={}, defaults={})'.format(
-        args, varargs, keywords, tuple(defaults))
+        args, varargs, keywords, defaults)
 
 
 def queue_dict(member, cur_name):
@@ -78,12 +82,18 @@ def queue_dict(member, cur_name):
         args = member.__module__ + "." + member.__name__
     else:
         try:
-            args = format_spec_doc(inspect.getargspec(member))
+            args = inspect.getargspec(member)
+            has_type_error = False
         except TypeError:  # special for PyBind method
             args = "  ".join([
                 line.strip() for line in pydoc.render_doc(member).split('\n')
                 if "->" in line
             ])
+            has_type_error = True
+
+        if not has_type_error:
+            args = format_spec(args)
+
     member_dict[cur_name] = "({}, ('document', '{}'))".format(args, doc_md5)
 
 
-- 
GitLab