未验证 提交 64824ac7 编写于 作者: C chengduo 提交者: GitHub

Add write after write dependence (#12632)

* Add write after write

* follow comment
上级 29fac3c0
...@@ -182,9 +182,11 @@ Graph::Graph(const ProgramDesc &program) : program_(program) { ...@@ -182,9 +182,11 @@ Graph::Graph(const ProgramDesc &program) : program_(program) {
} }
/** /**
* We only handle write after read(WAR), since it should not have a write * We should handle write after read(WAR) and write after write(WAW) here.
* after write in program. If there are write after write operators, we need * Because some of the operators of the program can be executed parallelly.
* prune them. * So, to make the program running in the right order, we should add the
* dependence of WAR and WAW.
*
* *
* https://en.wikipedia.org/wiki/Hazard_(computer_architecture)#Write_after_read_(WAR) * https://en.wikipedia.org/wiki/Hazard_(computer_architecture)#Write_after_read_(WAR)
*/ */
...@@ -201,6 +203,19 @@ Graph::Graph(const ProgramDesc &program) : program_(program) { ...@@ -201,6 +203,19 @@ Graph::Graph(const ProgramDesc &program) : program_(program) {
(*it_new)->inputs.empty() ? nullptr : (*it_new)->inputs[0]; (*it_new)->inputs.empty() ? nullptr : (*it_new)->inputs[0];
const auto &read_ops = (*it_old)->outputs; const auto &read_ops = (*it_old)->outputs;
PADDLE_ENFORCE(write_op, "The write_op should not be empty.");
// Add write after write dependence
ir::Node *upstream_op =
(*it_old)->inputs.empty() ? nullptr : (*it_old)->inputs[0];
if (upstream_op) {
ir::Node *dep_var = CreateControlDepVar();
write_op->inputs.push_back(dep_var);
upstream_op->outputs.push_back(dep_var);
dep_var->outputs.push_back(write_op);
dep_var->inputs.push_back(upstream_op);
}
for (auto *read_op : read_ops) { for (auto *read_op : read_ops) {
// Manually add a dependency var from read_op to write_op; // Manually add a dependency var from read_op to write_op;
if (read_op == write_op) { if (read_op == write_op) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册