diff --git a/paddle/fluid/framework/downpour_worker.cc b/paddle/fluid/framework/downpour_worker.cc index 0a54ef4be51447bc3184eea737050a04226ee805..e7dbf3b1131740748a5258455fdc76e2a50f1fc9 100644 --- a/paddle/fluid/framework/downpour_worker.cc +++ b/paddle/fluid/framework/downpour_worker.cc @@ -685,7 +685,6 @@ void DownpourWorker::TrainFiles() { *thread_scope_, tid, dense_grad_names_[tid], &push_sparse_status_, scale_datanorm_, cur_batch); } - VLOG(3) << "push dense gradient done."; // the following code should be more precise and clean diff --git a/paddle/fluid/framework/io/shell.cc b/paddle/fluid/framework/io/shell.cc index d63fee7f6e8cfe8c832226d79b5231c39ef1c326..ce0c3a767da3ca1331579e8f7d6a61ae3c71053d 100644 --- a/paddle/fluid/framework/io/shell.cc +++ b/paddle/fluid/framework/io/shell.cc @@ -119,16 +119,12 @@ static int shell_popen_fork_internal(const char* real_cmd, bool do_read, close(parent_end); if (child_end != child_std_end) { - if (dup2(child_end, child_std_end) != child_std_end) { - return -1; - } + PCHECK(dup2(child_end, child_std_end) == child_std_end); close(child_end); } close_open_fds_internal(); - if (execl("/bin/bash", "bash", "-c", real_cmd, NULL) < 0) { - return -1; - } + PCHECK(execl("/bin/bash", "bash", "-c", real_cmd, NULL) >= 0); exit(127); #endif }