From 3a73d3488410ffac3cc049fdce7d9fbf7a3a62f2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BC=A0=E6=98=A5=E4=B9=94?=
 <83450930+Liyulingyue@users.noreply.github.com>
Date: Wed, 1 Feb 2023 15:36:01 +0800
Subject: [PATCH] fix the div 0 error of sparse_embedding (#49948)

* fix the div 0 error of sparse_embedding

* add unittest
---
 python/paddle/fluid/contrib/layers/nn.py      |  3 ++
 .../unittests/test_sparse_embedding_op.py     | 37 +++++++++++++++++++
 2 files changed, 40 insertions(+)
 create mode 100644 python/paddle/fluid/tests/unittests/test_sparse_embedding_op.py

diff --git a/python/paddle/fluid/contrib/layers/nn.py b/python/paddle/fluid/contrib/layers/nn.py
index b836dfa451..d2aff8bfcf 100644
--- a/python/paddle/fluid/contrib/layers/nn.py
+++ b/python/paddle/fluid/contrib/layers/nn.py
@@ -793,6 +793,9 @@ def sparse_embedding(
         'paddle.static.nn.sparse_embedding',
     )
 
+    if input.size == 0:
+        raise ValueError("input size should not be 0")
+
     w = helper.create_parameter(
         attr=helper.param_attr,
         shape=size,
diff --git a/python/paddle/fluid/tests/unittests/test_sparse_embedding_op.py b/python/paddle/fluid/tests/unittests/test_sparse_embedding_op.py
new file mode 100644
index 0000000000..0e0beda679
--- /dev/null
+++ b/python/paddle/fluid/tests/unittests/test_sparse_embedding_op.py
@@ -0,0 +1,37 @@
+#  Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import unittest
+
+import paddle
+
+
+class TestSparseEmbeddingAPIError(unittest.TestCase):
+    def test_errors(self):
+        with paddle.fluid.dygraph.guard():
+            # The size of input in sparse_embedding should not be 0.
+            def test_0_size():
+                input = paddle.to_tensor([], dtype='int64')
+                paddle.static.nn.sparse_embedding(
+                    input,
+                    [2097152, 2097152, 2097152, 2097152],
+                    padding_idx=2097152,
+                )
+
+            self.assertRaises(ValueError, test_0_size)
+
+
+if __name__ == '__main__':
+    paddle.enable_static()
+    unittest.main()
-- 
GitLab