From 2468057da64799f00a482f0dda5b47ad7ecb607b Mon Sep 17 00:00:00 2001
From: minqiyang <minqiyang@baidu.com>
Date: Wed, 24 Oct 2018 16:59:31 +0800
Subject: [PATCH] Move code to SumSeqPoolGradFunctor

test=develop
---
 .../fluid/operators/math/sequence_pooling.cc  | 44 ++++++++++++-------
 1 file changed, 27 insertions(+), 17 deletions(-)

diff --git a/paddle/fluid/operators/math/sequence_pooling.cc b/paddle/fluid/operators/math/sequence_pooling.cc
index c2849d9776..7be8539a7b 100644
--- a/paddle/fluid/operators/math/sequence_pooling.cc
+++ b/paddle/fluid/operators/math/sequence_pooling.cc
@@ -157,6 +157,31 @@ class FirstSeqPoolFunctor {
   }
 };
 
+template <typename T>
+class SumSeqPoolGradFunctor {
+ public:
+  void operator()(const platform::CPUDeviceContext& context,
+                  const framework::Tensor& out_grad,
+                  framework::LoDTensor* in_grad) {
+    auto lod = in_grad->lod()[0];
+    int64_t out_w = out_grad.numel() / out_grad.dims()[0];
+    int64_t in_w = in_grad->numel() / in_grad->dims()[0];
+    PADDLE_ENFORCE(in_w == out_w);
+    const T* out_g_data = out_grad.data<T>();
+    T* in_g_data = in_grad->mutable_data<T>(context.GetPlace());
+    auto blas = math::GetBlas<platform::CPUDeviceContext, T>(context);
+    for (int i = 0; i < static_cast<int>(lod.size()) - 1; ++i) {
+      int64_t h = static_cast<int64_t>(lod[i + 1] - lod[i]);
+      int64_t in_offset = lod[i] * in_w;
+      const T* out_pos = out_g_data + i * out_w;
+      T* in_pos = in_g_data + in_offset;
+      for (int r = 0; r != h; ++r) {
+        blas.VCOPY(in_w, out_pos, in_pos + r * in_w);
+      }
+    }
+  }
+};
+
 template <typename T>
 class SequencePoolFunctor<platform::CPUDeviceContext, T> {
  public:
@@ -233,23 +258,8 @@ class SequencePoolGradFunctor<platform::CPUDeviceContext, T> {
     }
 
     if (pooltype == "SUM") {
-      auto lod = in_grad->lod()[0];
-      int64_t out_w = out_grad.numel() / out_grad.dims()[0];
-      int64_t in_w = in_grad->numel() / in_grad->dims()[0];
-      PADDLE_ENFORCE(in_w == out_w);
-      const T* out_g_data = out_grad.data<T>();
-      T* in_g_data = in_grad->mutable_data<T>(context.GetPlace());
-      auto blas = math::GetBlas<platform::CPUDeviceContext, T>(context);
-      for (int i = 0; i < static_cast<int>(lod.size()) - 1; ++i) {
-        int64_t h = static_cast<int64_t>(lod[i + 1] - lod[i]);
-        int64_t in_offset = lod[i] * in_w;
-        const T* out_pos = out_g_data + i * out_w;
-        T* in_pos = in_g_data + in_offset;
-        for (int r = 0; r != h; ++r) {
-          blas.VCOPY(in_w, out_pos, in_pos + r * in_w);
-        }
-      }
-
+      math::SumSeqPoolGradFunctor<T> sum_pool_grad;
+      sum_pool_grad(context, out_grad, in_grad);
       return;
     }
 
-- 
GitLab