"add c testing, python testing TODO"

go/pserver/cclient/cclient.go

@@ -121,14 +121,7 @@ func paddle_begin_init_params(client C.paddle_pserver_client) C.int {
 
 //export paddle_init_param
 func paddle_init_param(client C.paddle_pserver_client, param C.paddle_parameter, param_config unsafe.Pointer, config_len C.int) C.int {
-	et := pserver.ElementType(param.element_type)
-	name := C.GoString(param.name)
-	pc := pserver.ParameterWithConfig{
-		Param:  pserver.Parameter{Name: name, ElementType: et, Content: param.content, Length: para.content_len},
-		Config: cArrayToSlice(param_config, int(config_len)),
-	}
-	c := get(client)
-	err := c.InitParam(pc)
+	et
 
 	if err != nil {
 		if err.Error() == pserver.AlreadyInitialized {

go/pserver/cclient/test/dump_optimizer_proto.py

+import OptimizerConfig_pb2 as pb
+
+config = pb.OptimizerConfig()
+config.clip_norm = 0.1
+config.lr_policy = pb.OptimizerConfig.Const
+config.optimizer = pb.OptimizerConfig.SGD
+config.sgd.momentum = 0.0
+config.sgd.decay = 0.0
+config.sgd.nesterov = False
+config.const_lr.learning_rate = 0.1
+s = config.SerializeToString()
+with open("optimizer.pb.txt", 'w') as f:
+  f.write(s)

go/pserver/cclient/test/main.c

@@ -45,9 +45,20 @@ void getParams(paddle_pserver_client c) {
   }
 }
 
+
+
 int main() {
   char addr[] = "localhost:3000";
   paddle_pserver_client c = paddle_new_pserver_client(addr, 1);
+  char config_proto[1024];
+  size_t config_proto_len = 0;
+  ssize_t nread;
+  FILE *fp = fopen("optimizer.pb.txt", "r");
+  if(!fp) { fail(); }
+  while((nread = getline(&config_proto, &config_proto_len, fp)) != -1) {
+    printf("%s", config_proto);
+  }
+  fclose(fp);
 retry:
   if (paddle_begin_init_params(c)) {
     paddle_parameter param;
@@ -59,7 +70,7 @@ retry:
     param.name = name_a;
     param.content = content_a;
     param.content_len = 2000;
-    int error = paddle_init_param(c, param, NULL, 0);
+    int error = paddle_init_param(c, param, config_proto, config_proto_len);
     if (error != 0) {
       goto retry;
     }

go/pserver/cclient/test/test_train.py

@@ -22,6 +22,8 @@ def main():
     # create optimizer
     optimizer = paddle.optimizer.Momentum(momentum=0)
 
+    #TODO(zhihong) : replace optimizer with new OptimizerConfig
+
     trainer = paddle.trainer.SGD(cost=cost,
                                  parameters=parameters,
                                  update_equation=optimizer,

go/pserver/client_test.go

@@ -75,7 +75,9 @@ func TestClientFull(t *testing.T) {
 		var p pserver.Parameter
 		p.Name = "p_" + strconv.Itoa(i)
 		p.ElementType = pserver.Float32
-		p.Content = make([]byte, (i+1)*100)
+		ElementValue := make([]byte, (i+1)*100)
+		p.Content = &ElementValue[0]
+		p.Length = len(ElementValue)
 		err := c.InitParam(pserver.ParameterWithConfig{Param: p})
 		if err != nil {
 			t.Fatal(err)
@@ -92,7 +94,9 @@ func TestClientFull(t *testing.T) {
 		var g pserver.Gradient
 		g.Name = "p_" + strconv.Itoa(i)
 		g.ElementType = pserver.Float32
-		g.Content = make([]byte, (i+1)*100)
+		ElementValue := make([]byte, (i+1)*100)
+		g.Content = &ElementValue[0]
+		g.Length = len(ElementValue)
 		grads = append(grads, g)
 	}
 

python/paddle/v2/optimizer.py

@@ -5,6 +5,8 @@ import paddle.trainer_config_helpers.optimizers as v1_optimizers
 """
 Optimizers(update equation) for SGD method.
 
+TODO(zhihong) : create new optimizer with proto config, add new optimizer here
+
 TODO(yuyang18): Complete comments.
 """