Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
Annlix
ShellCheck
提交
bc810e9e
S
ShellCheck
项目概览
Annlix
/
ShellCheck
与 Fork 源项目一致
Fork自
镜像 / koalaman / ShellCheck
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
ShellCheck
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
bc810e9e
编写于
11月 03, 2012
作者:
V
Vidar Holen
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Added check for using a file in the same pipeline as a redirect
上级
54de7e7e
变更
1
显示空白变更内容
内联
并排
Showing
1 changed file
with
37 addition
and
6 deletion
+37
-6
shpell.hs
shpell.hs
+37
-6
未找到文件。
shpell.hs
浏览文件 @
bc810e9e
...
...
@@ -14,7 +14,7 @@ import qualified Control.Monad.State as Ms
import
Data.Maybe
import
Prelude
hiding
(
readList
)
import
System.IO
import
qualified
Text.Regex
as
Re
backslash
=
char
'
\\
'
...
...
@@ -141,8 +141,11 @@ wasIncluded p = option False (p >> return True)
-- Horrifying AST
data
Token
=
T_AND_IF
Id
|
T_OR_IF
Id
|
T_DSEMI
Id
|
T_Semi
Id
|
T_DLESS
Id
|
T_DGREAT
Id
|
T_LESSAND
Id
|
T_GREATAND
Id
|
T_LESSGREAT
Id
|
T_DLESSDASH
Id
|
T_CLOBBER
Id
|
T_If
Id
|
T_Then
Id
|
T_Else
Id
|
T_Elif
Id
|
T_Fi
Id
|
T_Do
Id
|
T_Done
Id
|
T_Case
Id
|
T_Esac
Id
|
T_While
Id
|
T_Until
Id
|
T_For
Id
|
T_Lbrace
Id
|
T_Rbrace
Id
|
T_Lparen
Id
|
T_Rparen
Id
|
T_Bang
Id
|
T_In
Id
|
T_NEWLINE
Id
|
T_EOF
Id
|
T_Less
Id
|
T_Greater
Id
|
T_SingleQuoted
Id
String
|
T_Literal
Id
String
|
T_NormalWord
Id
[
Token
]
|
T_DoubleQuoted
Id
[
Token
]
|
T_DollarExpansion
Id
[
Token
]
|
T_DollarBraced
Id
String
|
T_DollarVariable
Id
String
|
T_DollarArithmetic
Id
String
|
T_BraceExpansion
Id
String
|
T_IoFile
Id
Token
Token
|
T_HereDoc
Id
Bool
Bool
String
|
T_HereString
Id
Token
|
T_FdRedirect
Id
String
Token
|
T_Assignment
Id
String
Token
|
T_Array
Id
[
Token
]
|
T_Redirecting
Id
[
Token
]
Token
|
T_SimpleCommand
Id
[
Token
]
[
Token
]
|
T_Pipeline
Id
[
Token
]
|
T_Banged
Id
Token
|
T_AndIf
Id
(
Token
)
(
Token
)
|
T_OrIf
Id
(
Token
)
(
Token
)
|
T_Backgrounded
Id
Token
|
T_IfExpression
Id
[([
Token
],[
Token
])]
[
Token
]
|
T_Subshell
Id
[
Token
]
|
T_BraceGroup
Id
[
Token
]
|
T_WhileExpression
Id
[
Token
]
[
Token
]
|
T_UntilExpression
Id
[
Token
]
[
Token
]
|
T_ForIn
Id
String
[
Token
]
[
Token
]
|
T_CaseExpression
Id
Token
[([
Token
],[
Token
])]
|
T_Function
Id
String
Token
|
T_Arithmetic
Id
String
|
T_Script
Id
[
Token
]
deriving
(
Show
,
Eq
)
deriving
(
Show
)
lolHax
s
=
Re
.
subRegex
(
Re
.
mkRegex
"(Id [0-9]+)"
)
(
show
s
)
"(Id 0)"
instance
Eq
Token
where
(
==
)
a
b
=
(
lolHax
a
)
==
(
lolHax
b
)
analyzeScopes
f
i
=
mapM
(
analyze
f
i
)
...
...
@@ -890,7 +893,7 @@ tryWordToken s t = tryParseWordToken (string s) t `thenSkip` spacing
tryParseWordToken
parser
t
=
try
$
do
id
<-
getNextId
parser
lookAhead
(
keywordSeparator
)
try
$
lookAhead
(
keywordSeparator
)
return
$
t
id
g_AND_IF
=
tryToken
"&&"
T_AND_IF
...
...
@@ -929,7 +932,7 @@ g_Semi = do
notFollowedBy
g_DSEMI
tryToken
";"
T_Semi
keywordSeparator
=
eof
<|>
disregard
allspacing
<|>
(
disregard
$
oneOf
";()"
)
keywordSeparator
=
eof
<|>
disregard
whitespace
<|>
(
disregard
$
oneOf
";()"
)
readKeyword
=
choice
[
g_Then
,
g_Else
,
g_Elif
,
g_Fi
,
g_Do
,
g_Done
,
g_Esac
,
g_Rbrace
,
g_Rparen
,
g_DSEMI
]
...
...
@@ -1023,7 +1026,14 @@ verify f s = (getNotesWith readScript return s) == [] && (getNotesWith readScri
verifyNot
f
s
=
(
getNotesWith
readScript
return
s
)
==
(
getNotesWith
readScript
(
doAnalysis
f
)
s
)
canParse
p
s
=
isOk
(
p
>>
eof
)
s
checks
=
[
checkUuoc
,
checkForInQuoted
,
checkForInLs
,
checkMissingForQuotes
,
checkUnquotedExpansions
]
checks
=
[
checkUuoc
,
checkForInQuoted
,
checkForInLs
,
checkMissingForQuotes
,
checkUnquotedExpansions
,
checkRedirectToSame
]
prop_checkUuoc
=
verify
checkUuoc
"cat foo | grep bar"
...
...
@@ -1068,12 +1078,33 @@ checkUnquotedExpansions (T_SimpleCommand _ _ cmds) = mapM_ check cmds
check
_
=
return
()
checkUnquotedExpansions
_
=
return
()
prop_checkRedirectToSame
=
verify
checkRedirectToSame
"cat foo > foo"
prop_checkRedirectToSame2
=
verify
checkRedirectToSame
"cat lol | sed -e 's/a/b/g' > lol"
prop_checkRedirectToSame3
=
verifyNot
checkRedirectToSame
"cat lol | sed -e 's/a/b/g' > foo.bar && mv foo.bar lol"
checkRedirectToSame
s
@
(
T_Pipeline
_
list
)
=
mapM_
(
\
l
->
(
mapM_
(
\
x
->
doAnalysis
(
checkOccurences
x
)
l
)
(
getAllRedirs
list
)))
list
where
checkOccurences
(
T_NormalWord
exceptId
x
)
(
T_NormalWord
newId
y
)
=
when
(
x
==
y
&&
exceptId
/=
newId
)
(
do
let
note
=
Note
InfoC
$
"Make sure not to read and write the same file in the same pipeline"
addNoteFor
newId
$
note
addNoteFor
exceptId
$
note
)
checkOccurences
_
_
=
return
()
getAllRedirs
l
=
concatMap
(
\
(
T_Redirecting
_
ls
_
)
->
concatMap
getRedirs
ls
)
l
getRedirs
(
T_FdRedirect
_
_
(
T_IoFile
_
op
file
))
=
case
op
of
T_Greater
_
->
[
file
]
T_Less
_
->
[
file
]
T_DGREAT
_
->
[
file
]
_
->
[]
getRedirs
_
=
[]
checkRedirectToSame
_
=
return
()
lt
x
=
trace
(
show
x
)
x
main
=
do
s
<-
getContents
-- case rp readScript s of (Right parsed, _) -> putStrLn . show $ transform simplify parsed
-- (Left x, y) -> putStrLn $ "Can't parse: " ++ (show (x,y))
mapM
(
putStrLn
.
show
)
$
getNotes
s
return
()
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录