From 76b1482f64516bce64e264cb2c5447e4401766be Mon Sep 17 00:00:00 2001
From: Vidar Holen <spam@vidarholen.net>
Date: Sat, 18 Aug 2018 20:06:44 -0700
Subject: [PATCH] Avoid using `error` for option parsing failure

---
 shellcheck.hs | 46 ++++++++++++++++++++++++++++------------------
 1 file changed, 28 insertions(+), 18 deletions(-)

diff --git a/shellcheck.hs b/shellcheck.hs
index ef7eb24..668a71a 100644
--- a/shellcheck.hs
+++ b/shellcheck.hs
@@ -221,20 +221,28 @@ runFormatter sys format options files = do
                 then NoProblems
                 else SomeProblems
 
-parseColorOption colorOption =
-    case colorOption of
-        "auto"   -> ColorAuto
-        "always" -> ColorAlways
-        "never"  -> ColorNever
-        _        -> error $ "Bad value for --color `" ++ colorOption ++ "'"
-
-parseSeverityOption severityOption =
-    case severityOption of
-        "error"   -> ErrorC
-        "warning" -> WarningC
-        "info"    -> InfoC
-        "style"   -> StyleC
-        _         -> error $ "Bad value for --severity `" ++ severityOption ++ "'"
+parseEnum name value list =
+    case filter ((== value) . fst) list of
+        [(name, value)] -> return value
+        [] -> do
+            printErr $ "Unknown value for --" ++ name ++ ". " ++
+                       "Valid options are: " ++ (intercalate ", " $ map fst list)
+            throwError SupportFailure
+
+parseColorOption value =
+    parseEnum "color" value [
+        ("auto",   ColorAuto),
+        ("always", ColorAlways),
+        ("never",  ColorNever)
+        ]
+
+parseSeverityOption value =
+    parseEnum "severity" value [
+        ("error",   ErrorC),
+        ("warning", WarningC),
+        ("info",    InfoC),
+        ("style",   StyleC)
+        ]
 
 parseOption flag options =
     case flag of
@@ -265,10 +273,11 @@ parseOption flag options =
                 externalSources = True
             }
 
-        Flag "color" color ->
+        Flag "color" color -> do
+            option <- parseColorOption color
             return options {
                 formatterOptions = (formatterOptions options) {
-                    foColorOption = parseColorOption color
+                    foColorOption = option
                 }
             }
 
@@ -279,10 +288,11 @@ parseOption flag options =
                 }
             }
 
-        Flag "severity" severity ->
+        Flag "severity" severity -> do
+            option <- parseSeverityOption severity
             return options {
                 checkSpec = (checkSpec options) {
-                    csMinSeverity = parseSeverityOption severity
+                    csMinSeverity = option
                 }
             }
 
-- 
GitLab