From 6cf3256d4ce7fc8123a6d6a98d1f120740347780 Mon Sep 17 00:00:00 2001
From: Meco Man <920369182@qq.com>
Date: Sun, 27 Mar 2022 23:19:25 -0400
Subject: [PATCH] [device.c] fix the comment, add RT_DEBUG_LOG

---
 include/rtdebug.h |  4 ++++
 src/device.c      | 16 ++++++++--------
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/include/rtdebug.h b/include/rtdebug.h
index 55d46171a2..9fdb4ab910 100644
--- a/include/rtdebug.h
+++ b/include/rtdebug.h
@@ -52,6 +52,10 @@
 #define RT_DEBUG_IPC                   0
 #endif
 
+#ifndef RT_DEBUG_DEVICE
+#define RT_DEBUG_DEVICE                0
+#endif
+
 #ifndef RT_DEBUG_INIT
 #define RT_DEBUG_INIT                  0
 #endif
diff --git a/src/device.c b/src/device.c
index 9bfaf776d6..1079e2c38f 100644
--- a/src/device.c
+++ b/src/device.c
@@ -178,8 +178,8 @@ rt_err_t rt_device_init(rt_device_t dev)
             result = device_init(dev);
             if (result != RT_EOK)
             {
-                rt_kprintf("To initialize device:%s failed. The error code is %d\n",
-                           dev->parent.name, result);
+                RT_DEBUG_LOG(RT_DEBUG_DEVICE, ("To initialize device:%s failed. The error code is %d\n",
+                           dev->parent.name, result));
             }
             else
             {
@@ -216,8 +216,8 @@ rt_err_t rt_device_open(rt_device_t dev, rt_uint16_t oflag)
             result = device_init(dev);
             if (result != RT_EOK)
             {
-                rt_kprintf("To initialize device:%s failed. The error code is %d\n",
-                           dev->parent.name, result);
+                RT_DEBUG_LOG(RT_DEBUG_DEVICE, ("To initialize device:%s failed. The error code is %d\n",
+                           dev->parent.name, result));
 
                 return result;
             }
@@ -307,9 +307,9 @@ RTM_EXPORT(rt_device_close);
  *
  * @param size is the size of buffer.
  *
- * @return the actually read size on successful, otherwise negative returned.
+ * @return the actually read size on successful, otherwise 0 will be returned.
  *
- * @note since 0.4.0, the unit of size/pos is a block for block device.
+ * @note the unit of size/pos is a block for block device.
  */
 rt_size_t rt_device_read(rt_device_t dev,
                          rt_off_t    pos,
@@ -350,9 +350,9 @@ RTM_EXPORT(rt_device_read);
  *
  * @param size is the size of buffer.
  *
- * @return the actually written size on successful, otherwise negative returned.
+ * @return the actually written size on successful, otherwise 0 will be returned.
  *
- * @note since 0.4.0, the unit of size/pos is a block for block device.
+ * @note the unit of size/pos is a block for block device.
  */
 rt_size_t rt_device_write(rt_device_t dev,
                           rt_off_t    pos,
-- 
GitLab